Fix frontend-only backend setup and CORS handling by neubig · Pull Request #951 · OpenHands/agent-canvas

neubig · 2026-05-29T20:44:08Z

Summary

Make agent-server backends explicit (kind: "agent-server") while normalizing legacy stored kind: "local" values on read.
Split agent-server config sources by transport: same-origin backends come only from launcher config, remote backends come only from the backend manager UI, and cloud auth stays separate.
Stop baking launcher-only backend/session env into static builds; static/package launchers inject runtime config into index.html when they start a same-origin backend.
Remove VITE_BACKEND_BASE_URL; remote agent servers are added through the backend dialog.
Reuse the backend manager for missing, unauthorized, and likely CORS backend failures instead of a custom startup screen.
Stop implicitly probing /projects as a workspace parent; only user-stored workspace parents are scanned.

Launch Path Screenshots

Launch path	Expected startup state	Screenshot
`npm run dev`	Vite frontend with launcher-injected same-origin backend
`npm run dev:frontend`	Vite frontend with no launcher backend; backend manager opens
`npm run dev:static -- --skip-build`	Static frontend served locally with runtime-injected same-origin backend
`node scripts/static-server.mjs --dir build`	Static frontend with no launcher backend, matching dumb static hosting

The PNGs are committed under .pr/qa/ and listed in .pr/README.md.

Verification

npm run typecheck
npm test
npm run build
git diff --check
Whitespace-only file check against origin/main: comm -23 <(git diff --name-only origin/main...HEAD | sort) <(git diff -w --name-only origin/main...HEAD | sort)

🐳 Docker images for this PR

• GHCR package: https://github.com/OpenHands/agent-canvas/pkgs/container/agent-canvas

Component	Value
Image	`ghcr.io/openhands/agent-canvas`
Architectures	amd64, arm64
Agent Server	`ghcr.io/openhands/agent-server:1.24.0-python`
Automation	`openhands-automation==1.0.0a5`
Commit	`d126c4cdb9a001b7f2eedd6f3c6a5a3ee7971132`

Pull (multi-arch manifest)

# Multi-arch manifest — Docker automatically pulls the correct architecture
docker pull ghcr.io/openhands/agent-canvas:sha-d126c4c

Run

docker run -it --rm \
  -p 8000:8000 \
  ghcr.io/openhands/agent-canvas:sha-d126c4c

All tags pushed for this build

ghcr.io/openhands/agent-canvas:sha-d126c4c-amd64
ghcr.io/openhands/agent-canvas:codex-frontend-backend-cors-flow-amd64
ghcr.io/openhands/agent-canvas:pr-951-amd64
ghcr.io/openhands/agent-canvas:sha-d126c4c-arm64
ghcr.io/openhands/agent-canvas:codex-frontend-backend-cors-flow-arm64
ghcr.io/openhands/agent-canvas:pr-951-arm64
ghcr.io/openhands/agent-canvas:sha-d126c4c
ghcr.io/openhands/agent-canvas:codex-frontend-backend-cors-flow
ghcr.io/openhands/agent-canvas:pr-951

About Multi-Architecture Support

Each tag (e.g., sha-d126c4c) is a multi-arch manifest supporting both amd64 and arm64
Docker automatically pulls the correct architecture for your platform
Individual architecture tags (e.g., sha-d126c4c-amd64) are also available if needed

vercel · 2026-05-29T20:44:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agent-canvas	Ready	Preview, Comment	Jun 1, 2026 11:53am

- avoid seeding a backend for frontend-only dev launches - route missing or unauthorized agent server preflight to backend settings - surface CORS failures with localized agent-server launch guidance - keep create-conversation CORS errors to a single toast

neubig · 2026-05-30T03:47:34Z

@OpenHands /iterate

openhands-ai · 2026-05-30T03:48:21Z

Uh oh! There was an unexpected error starting the job :(

neubig · 2026-05-30T04:13:32Z

@OpenHands /iterate

openhands-ai · 2026-05-30T04:14:18Z

Uh oh! There was an unexpected error starting the job :(

neubig · 2026-05-30T04:16:22Z

@OpenHands /iterate

openhands-ai · 2026-05-30T04:16:48Z

I'm on it! neubig can track my progress at all-hands.dev

….tsx conflict Conflict in src/root.tsx: PR replaces MissingAgentServerScreen (modal-based) with a redirect to /settings/backend + AgentServerConnectionScreen; main added links() export for the favicon. Resolution: keep PR's redirect logic, preserve links() export. Co-authored-by: openhands <openhands@all-hands.dev>

The PR changed readStoredBackends() to only seed the default local backend when hasConfiguredAgentServerDefaults() is true (deployed with env vars). In Vitest environments without VITE_BACKEND_BASE_URL, the function returns false so no seeding occurs. - active-backend-context.test.tsx: mock hasConfiguredAgentServerDefaults to return true so seeding tests still exercise the production path - agent-server-compatibility-bundled-pin.test.ts: same mock so hasEffectiveLocalBackend() returns true for the no-local-backends case - add-backend-modal.test.tsx: change toHaveLength(2) → toHaveLength(1) since without env defaults no default backend is seeded before the test Co-authored-by: openhands <openhands@all-hands.dev>

neubig · 2026-05-30T04:38:49Z

Addressed CI failures in 649bc8a. Two commits were pushed:

Merge main → branch (18dfa33): Resolved merge conflict in src/root.tsx — kept the PR's redirect-to-/settings/backend approach while preserving the links() favicon export that main added.
Fix conditional backend seeding tests (649bc8a): The PR changed readStoredBackends() to only seed the default local backend when hasConfiguredAgentServerDefaults() is true (i.e., env vars are set or it's a production build). Vitest environments have no VITE_BACKEND_BASE_URL and run in DEV mode, so the function returned false and seeding was skipped, causing three test failures:
- active-backend-context.test.tsx: added vi.mock for hasConfiguredAgentServerDefaults → true (production-like scenario)
- agent-server-compatibility-bundled-pin.test.ts: same mock so hasEffectiveLocalBackend() returns true for the no-local-backends case
- add-backend-modal.test.tsx: changed toHaveLength(2) → toHaveLength(1) (no seeded default without env defaults)

This comment was created by an AI agent (OpenHands) on behalf of the PR author.

openhands-ai · 2026-05-30T04:50:11Z

Summary of Work on PR #951

What was requested

The /iterate command was invoked — drive PR #951 to a CI-green, merge-ready state.

What was done

✅ Identified the problem

The PR branch codex/frontend-backend-cors-flow had diverged significantly from main, causing a merge conflict in src/root.tsx and making the PR CONFLICTING (unmergeable).

✅ Resolved the merge conflict

File: src/root.tsx
Resolution: Kept the PR's redirect-to-/settings/backend + AgentServerConnectionScreen approach (the PR's core feature), while preserving the links() favicon export (LinksFunction) that main added independently. Dropped MissingAgentServerScreen which the PR intentionally replaced.

✅ Fixed CI test failures (3 tests in 2 CI jobs)

The PR had changed readStoredBackends() to only seed the default local backend when hasConfiguredAgentServerDefaults() is true (i.e., VITE_BACKEND_BASE_URL is set or it's a production build). In Vitest, neither condition holds, so seeding was skipped, breaking tests that assumed it always happened:

Test File	Fix Applied
`__tests__/contexts/active-backend-context.test.tsx`	Added `vi.mock` of `hasConfiguredAgentServerDefaults → true` to simulate production deployment
`__tests__/api/agent-server-compatibility-bundled-pin.test.ts`	Same mock so `hasEffectiveLocalBackend()` returns `true` for cloud-only backend scenario
`__tests__/components/backends/add-backend-modal.test.tsx`	Changed `toHaveLength(2) → toHaveLength(1)` (no seeded default in test env)

✅ Final CI state

12/12 checks passing (ubuntu ✅, windows ✅, snapshots ✅, Docker ✅, Vercel ✅)
Mergeable — no conflicts
0 unresolved review threads

⏳ Remaining blocker

The PR is REVIEW_REQUIRED — it needs a human maintainer's approval. The automated PR-review bot workflows (pr-review-by-openhands.yml) were deleted from main before this PR was merged, so no bot review is available. This requires human action.

Changes are concise

All three commits are directly required to address the PR's state: one merge commit (necessary to resolve conflicts) and one test-fix commit (necessary to make CI pass). No extraneous changes were made.

all-hands-bot · 2026-05-30T15:39:51Z

✅ Review complete.

This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here.

all-hands-bot

Code Review

This is a well-structured PR that addresses three distinct but related pain points: the frontend-only dev workflow defaulting to a backend that may not exist, the absence of actionable CORS error guidance, and the "unauthorized" vs "unreachable" distinction for backend errors. The overall design is sound. A few issues are worth addressing.

✅ Strengths

CORS detection + localized guidance — Surfacing OH_ALLOW_CORS_ORIGINS instructions with translated detail strings is excellent UX for the cross-origin deployment scenario. The frontendOrigin !== backendOrigin guard prevents false positives for same-origin failures.
AgentServerUnavailableReason discriminated union — Properly separates "unauthorized" (401/403) from "unreachable" (network/other HTTP) failure modes, enabling AgentServerConnectionScreen to give context-specific guidance.
preflightAgentServerAccess two-phase check — Probing /server_info for reachability then /api/settings for auth is clean; distinguishes the two failure modes without a dedicated auth endpoint.
Navigate to /settings/backend instead of modal overlay — The connection screen gets its own URL, the modal-on-top-of-nothing pattern is gone, and the backend-settings.tsx redirect-to-home on successful reconnect is an elegant post-recovery UX.
Query key scoped to backend identity — WEB_CLIENT_CONFIG_BY_BACKEND(backend) prevents stale config from surviving a backend switch.
Stale auto-seeded backend cleanup — Removing the empty-apiKey default-local entry when defaults are no longer configured avoids phantom backends after switching to frontend-only mode.

🔴 Issue 1 — Silent error swallowing in `HomeChatLauncher`

The onError callback now dismisses the loading toast without any user-facing feedback. Previously it called displayErrorToast for any error. Now, only CORS errors surfaced via the useConfig/AgentServerConnectionScreen path are visible — but that path only covers the initial config load, not conversation creation.

Any createConversation failure (network timeout, server 5xx, SDK error, non-CORS reasons) will silently dismiss the toast with no indication to the user. Consider at minimum showing a fallback for non-CORS errors, or add a comment explaining which path surfaces them.

🟡 Issue 2 — Inconsistent normalization in `isAutoSeededDefaultLocalBackend`

In src/api/backend-registry/storage.ts:

LEGACY_FRONTEND_ONLY_DEV_BACKEND_URL ("http://127.0.0.1:8000") is compared against an already-normalized host without itself being normalized. If normalizeHostForComparison strips the protocol prefix or trailing slashes, this branch will never match and the legacy cleanup becomes dead code.

Fix: host === normalizeHostForComparison(LEGACY_FRONTEND_ONLY_DEV_BACKEND_URL)

🟡 Issue 3 — English-only browser error strings for CORS detection

In src/utils/agent-server-cors-error.ts, FETCH_NETWORK_ERROR_FRAGMENTS contains English-language browser error messages. Browsers with non-English UI locales or future browser versions that change error wording will silently miss CORS detection. The detection degrades gracefully (no false positives given the frontendOrigin !== backendOrigin guard), but a brief comment explaining the heuristic and its known limitations would help maintainers.

🟢 Minor — Dead code in `containsHtmlDocument` regex

In src/api/agent-server-compatibility.ts, the regex includes <!doctype and <html (HTML-entity-encoded forms). SDK error messages come from raw HTTP response bodies and contain literal < characters, not <. These variants appear to be dead code; removing them simplifies the regex without changing behavior.

This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation

neubig · 2026-05-30T15:57:40Z

@OpenHands /iterate

openhands-ai · 2026-05-30T15:58:29Z

Uh oh! There was an unexpected error starting the job :(

neubig · 2026-05-30T16:20:54Z

@OpenHands /iterate

openhands-ai · 2026-05-30T16:21:38Z

I'm on it! neubig can track my progress at all-hands.dev

github-actions · 2026-05-31T17:42:12Z

PR Artifacts Notice

This PR contains a .pr/ directory with PR-specific artifacts. This directory will be automatically removed when the PR is approved.

Fork PRs require manual cleanup before merging.

…d-cors-flow # Conflicts: # __tests__/utils/mcp-marketplace-utils.test.ts

all-hands-bot · 2026-05-31T19:20:38Z

✅ Review complete.

This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here.

all-hands-bot

Overview

This is a well-structured refactor with a clear goal: stop conflating "same-origin launcher-managed backend" with "any local backend", and stop baking launcher-specific config into static builds at compile time.

The key changes are:

kind: "local" → kind: "agent-server" across the codebase, with transparent migration of stored values on read via normalizeBackendKind.
AgentServerTransport ("same-origin" | "remote") distinguishes whether the frontend and agent-server share an origin (static/package launchers) from a separately hosted backend added via the UI. This drives getBackendBaseUrl() to return window.location.origin for same-origin backends, eliminating hardcoded host comparisons elsewhere.
AgentCanvasRuntimeConfig / window.__AGENT_CANVAS_RUNTIME_CONFIG__ replaces the openhands-agent-server-config localStorage-write-on-load approach with a clean runtime injection point in index.html, meaning session keys are no longer baked into the bundle at publish time.
CORS error utility surfaces an actionable message when a cross-origin network failure is likely a CORS misconfiguration, with origin-mismatch guard to prevent false positives.
getBackendBaseUrl() centralises URL resolution so the "same-origin → window.location.origin" rule can't drift out of sync across callers.
Implicit /projects workspace parent removal: the dev-only heuristic that probed /projects was causing noisy 404s against remote backends; good cleanup.
Fallback screen simplified: MissingAgentServerScreen now renders AddBackendModal directly (no lazy ManageBackendsModal) with showCloseButton=false, forcing users to configure a backend before proceeding. The new test cases covering 401/unauthorized flows are a solid addition.

The migration path (normalizeBackendKind, normalizeAgentServerTransport) handles old stored values cleanly, and coverage for the new auth-failure root states is thorough.

A few issues worth addressing are noted below.

This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation

all-hands-bot · 2026-05-31T19:24:53Z

+  "failed to fetch",
+  "load failed",
+  "networkerror when attempting to fetch resource",
+] as const;


🟠 Important: browser error message matching is fragile across locales and browser versions

The three strings (, , ) are hardcoded English error messages from Chromium, Safari, and Firefox respectively. They will miss CORS failures in non-English browser locales (Firefox and Safari localise messages in some versions) and in future browser releases that change the wording.

All real CORS/network failures from surface as in every spec-compliant browser. Since the origin-mismatch guard at the call site already confirms the backend is cross-origin, checking first gives a much more robust signal:

Keeping the string fallback as a secondary check preserves behaviour for SDK-wrapped errors that strip the original identity.

all-hands-bot · 2026-05-31T19:24:53Z

@@ -417,9 +437,12 @@ async function handleStatic(req, res, dirAbs, sessionApiKey = null) {
    filePath = resolve(filePath, "index.html");
  }



🟠 Important: property name collision is confusing

The local variable (built in ) has a property also named (the parsed JSON payload). requires double-reading and the same pattern appears a second time a few lines below, making both branches hard to scan.

Consider renaming the inner property when building the composite object in :

Then replace with throughout and . This also makes self-documenting.

all-hands-bot · 2026-05-31T19:24:53Z

+    VITE_AGENT_SERVER_PROXY_TARGET: configuredProxyTarget,
    VITE_USE_TLS = "false",
    VITE_FRONTEND_PORT = "3001",
    VITE_INSECURE_SKIP_VERIFY = "false",


🟡 **Suggestion: silently overrides all file values, not just **

The spread order means any shell/CI variable already set takes precedence over for every key destructured here, not just the new proxy target. This is almost certainly intentional to let pass without requiring a file, but it can silently shadow developer overrides for , , etc.

A narrower alternative is to only promote the new variable from :

If the current broad-override behaviour is intentional, a short comment explaining why would help future readers avoid inadvertently reverting it.

all-hands-bot · 2026-05-31T19:24:53Z

+  if (typeof value !== "object" || value === null) return null;
  const v = value as Partial<Backend>;
-  return (
+  const rawKind = (value as { kind?: unknown }).kind;


🟡 Suggestion: migration values / should be documented or removed once fully migrated

maps legacy values ( → , → ). If these are one-time migration aliases for values that were written by a previous version, a brief comment noting which release introduced and which release can remove them would help avoid keeping dead migration code indefinitely. If they are still being written somewhere, that write site should be updated to use the canonical values.

neubig · 2026-06-01T11:54:01Z

@OpenHands

Actually we have a several-step onboarding process already (select agent, backend, llm, starting prompt), so I don't think that we need to add the initial screen for onboarding a backend. OTOH, we need to make sure that the onboarding process works regardless of they way of launching. Fix this PR to rely on the onboarding process instead of adding an extra screen.

openhands-ai · 2026-06-01T11:54:47Z

Uh oh! There was an unexpected error starting the job :(

github-actions · 2026-06-01T12:01:45Z

📸 Snapshot Test Report

Warning

Snapshot comparison step crashed (timeout, OOM, or runner error) — diff results below may be incomplete or absent.
Check the CI logs for the full error output (look for the "Run snapshot comparison" step).

✅ 4 snapshots changed — acknowledged via the update-snapshots label. New baselines will be uploaded when this PR merges.

Category	Count
🔴 Changed	4
🆕 New	0
✅ Unchanged	69
Total	73

🔴 Changed snapshots (4)

`backends-extended` — 2 snapshots

backend-cancel-nothing-saved

Expected (main)	Actual (PR)	Diff

backend-manage-two-listed

Expected (main)	Actual (PR)	Diff

`backends`

backend-manage-modal

Expected (main)	Actual (PR)	Diff

`onboarding`

onboarding-step-1-check-backend

Expected (main)	Actual (PR)	Diff

✅ Unchanged snapshots (69)

archived-conversation

conversation-panel-with-archived-badges
conversation-view-archived
conversation-view-sandbox-error

automations

automations-delete-modal
automations-list-active-inactive
automations-no-automations
automations-search-no-results

backends-extended

backend-add-blank-disabled
backend-add-cloud-advanced-open
backend-add-cloud-no-key-disabled
backend-add-cloud-with-key-enabled
backend-add-form-partially-filled
backend-add-invalid-url-disabled
backend-add-local-ready
backend-add-name-only-disabled
backend-add-two-column-layout
backend-add-whitespace-host-disabled
backend-after-switch
backend-dropdown-two-backends
backend-edit-prefilled
backend-manage-after-removal
backend-remove-cancelled
backend-remove-confirmation
backend-switch-overlay

backends

backend-add-modal
backend-selector-open

changes-tab

changes-deleted-file
changes-diff-viewer
changes-empty

collapsible-thinking

reasoning-content-collapsed
reasoning-content-expanded
think-action-collapsed
think-action-expanded

mcp-page

mcp-custom-server-1-editor-open
mcp-custom-server-2-url-filled
mcp-custom-server-3-all-filled
mcp-custom-server-4-installed
mcp-custom-server-editor
mcp-empty-installed
mcp-search-filtered
mcp-slack-install-1-marketplace
mcp-slack-install-2-modal
mcp-slack-install-3-filled
mcp-slack-install-4-installed

onboarding

onboarding-step-0-choose-agent
onboarding-step-2-setup-llm
onboarding-step-3-say-hello

projects-workspace-browser

projects-workspace-browser

settings-page

add-backend-modal
analytics-consent-modal
home-screen
settings-app-page
settings-page

settings-secrets

secrets-add-form-filled
secrets-add-form
secrets-after-save
secrets-delete-confirm
secrets-list

settings-verification

condenser-settings
verification-settings-off
verification-settings-on

sidebar

sidebar-collapsed
sidebar-conversation-panel
sidebar-filter-menu

skills-page

skills-empty
skills-loaded
skills-no-match
skills-search-filtered
skills-type-filter

Generated by the Snapshot Tests workflow. This comment was created by an AI agent (OpenHands) on behalf of the repo maintainers.

vercel Bot deployed to Preview May 29, 2026 20:44 View deployment

neubig force-pushed the codex/frontend-backend-cors-flow branch from c797687 to 66db084 Compare May 29, 2026 22:07

vercel Bot deployed to Preview May 29, 2026 22:08 View deployment

neubig force-pushed the codex/frontend-backend-cors-flow branch from 66db084 to 9d7ca75 Compare May 30, 2026 03:37

vercel Bot deployed to Preview May 30, 2026 03:38 View deployment

vercel Bot deployed to Preview May 30, 2026 04:23 View deployment

vercel Bot deployed to Preview May 30, 2026 04:39 View deployment

neubig added the review-this label May 30, 2026

Merge branch 'main' into codex/frontend-backend-cors-flow

d7b0070

vercel Bot deployed to Preview May 30, 2026 15:40 View deployment

all-hands-bot reviewed May 30, 2026

View reviewed changes

Comment thread src/components/features/home/home-chat-launcher.tsx

Comment thread src/api/backend-registry/storage.ts Outdated

Comment thread src/utils/agent-server-cors-error.ts

Gate canvas UI tool on backend capability

9bc2534

vercel Bot deployed to Preview May 30, 2026 16:20 View deployment

neubig force-pushed the codex/frontend-backend-cors-flow branch from e874ba6 to 1fac6c2 Compare May 31, 2026 17:00

vercel Bot deployed to Preview May 31, 2026 17:01 View deployment

github-actions Bot added a commit that referenced this pull request May 31, 2026

snapshot images for PR #951 run 26718829008

3936212

neubig force-pushed the codex/frontend-backend-cors-flow branch from 1fac6c2 to d81e2e2 Compare May 31, 2026 17:12

vercel Bot deployed to Preview May 31, 2026 17:13 View deployment

github-actions Bot added a commit that referenced this pull request May 31, 2026

snapshot images for PR #951 run 26719102291

f1446b2

neubig force-pushed the codex/frontend-backend-cors-flow branch from d81e2e2 to 72f550f Compare May 31, 2026 17:24

vercel Bot deployed to Preview May 31, 2026 17:25 View deployment

Clarify agent server transport config

e977698

neubig force-pushed the codex/frontend-backend-cors-flow branch from 72f550f to e977698 Compare May 31, 2026 17:30

github-actions Bot added a commit that referenced this pull request May 31, 2026

snapshot images for PR #951 run 26719362550

f926f56

vercel Bot deployed to Preview May 31, 2026 17:31 View deployment

github-actions Bot added a commit that referenced this pull request May 31, 2026

snapshot images for PR #951 run 26719507798

4db9eff

Add PR QA screenshots

d50ef17

vercel Bot deployed to Preview May 31, 2026 17:42 View deployment

github-actions Bot added a commit that referenced this pull request May 31, 2026

snapshot images for PR #951 run 26719773261

68651b3

Stop implicit workspace parent probe

6c48b07

vercel Bot deployed to Preview May 31, 2026 18:06 View deployment

Merge remote-tracking branch 'origin/main' into codex/frontend-backen…

ca994ed

…d-cors-flow # Conflicts: # __tests__/utils/mcp-marketplace-utils.test.ts

vercel Bot deployed to Preview May 31, 2026 18:17 View deployment

github-actions Bot added a commit that referenced this pull request May 31, 2026

snapshot images for PR #951 run 26720592387

6574f46

Refactor launcher backend runtime config

40cbb0f

all-hands-bot reviewed May 31, 2026

View reviewed changes

neubig added 2 commits June 1, 2026 06:58

Show add backend connection errors

d08e5f4

Merge branch 'main' into codex/frontend-backend-cors-flow

d126c4c

		@@ -417,9 +437,12 @@ async function handleStatic(req, res, dirAbs, sessionApiKey = null) {
		filePath = resolve(filePath, "index.html");
		}

Conversation

neubig commented May 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Launch Path Screenshots

Verification

Uh oh!

vercel Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neubig commented May 30, 2026

Uh oh!

openhands-ai Bot commented May 30, 2026

Uh oh!

neubig commented May 30, 2026

Uh oh!

openhands-ai Bot commented May 30, 2026

Uh oh!

neubig commented May 30, 2026

Uh oh!

openhands-ai Bot commented May 30, 2026

Uh oh!

neubig commented May 30, 2026

Uh oh!

openhands-ai Bot commented May 30, 2026

Summary of Work on PR #951

What was requested

What was done

✅ Identified the problem

✅ Resolved the merge conflict

✅ Fixed CI test failures (3 tests in 2 CI jobs)

✅ Final CI state

⏳ Remaining blocker

Changes are concise

Uh oh!

all-hands-bot commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

all-hands-bot left a comment

Choose a reason for hiding this comment

Code Review

✅ Strengths

🔴 Issue 1 — Silent error swallowing in HomeChatLauncher

🟡 Issue 2 — Inconsistent normalization in isAutoSeededDefaultLocalBackend

🟡 Issue 3 — English-only browser error strings for CORS detection

🟢 Minor — Dead code in containsHtmlDocument regex

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neubig commented May 30, 2026

Uh oh!

openhands-ai Bot commented May 30, 2026

Uh oh!

neubig commented May 30, 2026

Uh oh!

openhands-ai Bot commented May 30, 2026

Uh oh!

github-actions Bot commented May 31, 2026

Uh oh!

all-hands-bot commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

all-hands-bot left a comment

Choose a reason for hiding this comment

Overview

Uh oh!

all-hands-bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

all-hands-bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

all-hands-bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

all-hands-bot May 31, 2026

Choose a reason for hiding this comment

Uh oh!

neubig commented Jun 1, 2026

neubig commented May 29, 2026 •

edited by github-actions Bot

Loading

vercel Bot commented May 29, 2026 •

edited

Loading

all-hands-bot commented May 30, 2026 •

edited

Loading

🔴 Issue 1 — Silent error swallowing in `HomeChatLauncher`

🟡 Issue 2 — Inconsistent normalization in `isAutoSeededDefaultLocalBackend`

🟢 Minor — Dead code in `containsHtmlDocument` regex

all-hands-bot commented May 31, 2026 •

edited

Loading

`backends-extended` — 2 snapshots

`backends`

`onboarding`