feat: add GitHub Actions skill for workflow creation and debugging#56
feat: add GitHub Actions skill for workflow creation and debugging#56juanmichelini wants to merge 8 commits into
Conversation
- Add comprehensive GitHub Actions skill with SKILL.md - Include practical examples for testing, debugging, and best practices - Cover common pitfalls like action deployment requirements and permissions - Add README.md with detailed scenarios and use cases - Register skill in marketplace.json Closes #55 Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable - Technically solid content but violates progressive disclosure principle.
Verdict: ✅ Worth merging with strong recommendation to refactor for efficiency.
Key Insight: You built a comprehensive reference manual when you needed a concise decision guide. SKILL.md at 530 lines will burn significant context tokens every time an agent loads it—that's the wrong data structure for the progressive disclosure use case.
- Consolidated repetitive content into a single 'Critical Rules' section - Clarified that debug steps should be used for NEW actions OR tricky issues, not always - Removed redundant explanations scattered throughout the document - Updated both SKILL.md and README.md for consistency Addresses feedback from @juanmichelini
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🔴 Needs improvement - Violates AgentSkills progressive disclosure architecture
Verdict: Content quality is solid, but the data structure problem identified in previous reviews remains unaddressed.
Key Insight: SKILL.md should be a 50-80 line decision guide, not a 526-line reference manual—that's an architectural requirement, not a style preference.
|
@OpenHands address the reviewers points |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
- Reduced SKILL.md from 526 to 81 lines (within 50-80 line target) - Kept frontmatter and Critical Rules section (got positive review feedback) - Added concise Quick Patterns section showing 3 action types - Condensed Key Gotchas to 4 most critical issues - Moved detailed content to README.md (examples, debugging, testing, best practices) - Eliminated redundancy between SKILL.md and README.md - README.md now contains comprehensive detailed reference material Addresses reviewer feedback: - Progressive disclosure architecture now properly implemented - SKILL.md is a decision guide, not a reference manual - Reduced context token usage for skill loading - No repeated content between files
Summary of Changes MadeI've successfully addressed all reviewer feedback on PR #56 for the GitHub Actions skill. The changes have been committed and pushed to the remote branch. ✅ Request Completion ChecklistReviewer Points Addressed:
Changes Made (2 files modified)skills/github-actions/SKILL.md (526 → 81 lines):
skills/github-actions/README.md (285 → 607 lines):
Validation
PR #56 has been updated and now properly implements the AgentSkills progressive disclosure specification. |
|
@OpenHands remove the Quick Patterns section. Add comments to make sure the agent is effective when testing and understanding actions. We want to monitor them, we want to read logs, we want to figure out what's actually happenning not guessing. Think best practices for developing an action with confidence and add them. Notice that actions have costs so we should take that into account when deciding a plan to test and monitor. |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
- Remove Quick Patterns section (syntax examples moved to README) - Add Testing & Monitoring Strategy focused on effectiveness - Emphasize cost awareness (CI minutes consumption) - Add practical debugging workflow with gh CLI commands - Focus on reading logs and understanding actual behavior vs guessing - Include visibility best practices (debug steps for inputs/outputs) Addresses reviewer feedback to make skill about SWE effectiveness, not syntax.
Summary of ChangesI've successfully addressed the reviewer's feedback on PR #56 for the GitHub Actions skill. Here's what was changed: ✅ Request Completion Checklist
Changes Are ConciseThe modification was surgical - only the "Quick Patterns" section (lines 26-65) was replaced with the new "Testing & Monitoring Strategy" section. No extraneous changes were made. The file went from 82 to 88 lines, with the increase coming from more detailed debugging guidance as requested. What ChangedThe SKILL.md now leads with practical effectiveness instead of syntax examples:
Commit pushed: The skill is now focused on working with GitHub Actions as a professional SWE - monitoring, understanding, and debugging with confidence rather than just syntax knowledge. |
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable but could be more concise
Verdict: ✅ Worth merging - Massive improvement from 526→87 lines, but 45 lines of how-to content still belongs in README.md
Key Insight: The "Critical Rules" section shows what good progressive disclosure looks like—apply that pattern to the entire SKILL.md by moving detailed debugging workflows to README.md.
Removed detailed sections on key concepts, scenarios, common pitfalls, advanced patterns, and best practices from the GitHub Actions README.
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solid improvement (526→78 lines) but still mixing decision criteria with tutorial content per previous reviews.
|
@OpenHands address reviewrs conerns and mark for rereview |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
- Fix grammar: 'should tested' -> 'should be tested' - Move detailed gh CLI commands, debugging workflow, and YAML debug-step examples from SKILL.md to README.md (progressive disclosure - SKILL.md is now 43 lines) - Keep core principles (cost awareness, monitor, read logs, print actual values, local-first, smallest reproduction) in SKILL.md as a concise decision guide - Expand README.md with full debugging loop, gh run/checks commands, log-reading patterns, act usage and caveats, visibility/debug-step example with runner.debug gating, cost-awareness practices, and pitfalls reference Co-authored-by: openhands <openhands@all-hands.dev>
Reviewer Concerns Addressed — Ready for Re-reviewAll three unresolved review threads from the last bot review have been addressed in 6dd9504 and the threads have been resolved.
What's in SKILL.md now (43 lines)
What's in README.md now (~189 lines)
Verification
This comment was created by an AI agent (OpenHands) on behalf of @juanmichelini. |
SummaryAddressed all three remaining unresolved reviewer concerns on PR #56 and marked it for re-review. Request Completion Checklist
ConcisenessOnly two files changed: |
|
✅ Review complete. This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here. |
all-hands-bot
left a comment
There was a problem hiding this comment.
Good addition — the README is thorough, the gh command examples are accurate, and the cost-awareness / debug-loop framing is genuinely useful. There is one blocking bug (wrong source path in marketplace.json) and a couple of issues in SKILL.md worth addressing before merge.
This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation
| }, | ||
| { | ||
| "name": "github-actions", | ||
| "source": "./github-actions", |
There was a problem hiding this comment.
🔴 Critical: wrong source path — will break skill loading.
Every other entry in this file uses ./skills/<name> (e.g. ./skills/agent-creator, ./skills/github-pr-review). This entry uses ./github-actions, which resolves to a non-existent .plugin/github-actions/ directory.
| "source": "./github-actions", | |
| "source": "./skills/github-actions", |
There was a problem hiding this comment.
Respectfully pushing back on this one. The file declares metadata.pluginRoot: "./skills" at the top, and every existing entry uses ./<name> (e.g. ./github, ./github-pr-review, ./gitlab, ./agent-creator). They all resolve to ./skills/<name> via pluginRoot. Changing this entry to ./skills/github-actions would actually break it — it would resolve to ./skills/skills/github-actions, inconsistent with every other plugin in the file.
The current ./github-actions is consistent with the existing convention. Happy to change it if the convention itself is being updated, but a one-off change here would be the outlier.
|
@OpenHands address reviewrs concerns and mark for rereview |
|
I'm on it! juanmichelini can track my progress at all-hands.dev |
…g, docs - SKILL.md: replace overly generic triggers (workflow, ci/cd) with GitHub Actions-specific ones to prevent false positives - SKILL.md: clarify pull_request_target risk (RCE if checking out fork code) - README.md: note Docker prerequisite for act - README.md: correct pitfall #5 - it's non-pull_request triggers (schedule/workflow_dispatch) that need to be on default branch, not pull_request workflows Co-authored-by: openhands <openhands@all-hands.dev>
Reviewer Concerns Addressed — Ready for Re-reviewAddressed the 5 unresolved threads from the last bot review in 888acf2.
Threads 2–5 are resolved. Thread 1 left unresolved for human reviewer judgement since the suggested fix appears factually incorrect. This comment was generated by an AI agent (OpenHands) on behalf of @juanmichelini. |
SummaryAddressed all 5 unresolved review threads on PR #56 in commit Request Completion Checklist
Changes Are ConciseTotal diff: 2 files, 6 insertions, 5 deletions. Every change directly addresses a specific reviewer comment — no extraneous edits, no scope creep beyond what was requested. PR: #56 |
|
✅ Review complete. This review was performed through OpenHands Cloud Automation. You can log in and view the conversation here. |
all-hands-bot
left a comment
There was a problem hiding this comment.
Good progress — the previous concerns about overly generic triggers, security clarity, the Docker prerequisite for , and the pitfall #5 wording have all been addressed. The path in is correct: means resolves to — the previous review on that point was incorrect.
One structural gap remains before this can merge: the directory is missing the plugin scaffolding that every other skill in the repository ships.
This review was generated by an AI agent (OpenHands) on behalf of the user through OpenHands Automation. View conversation
| @@ -0,0 +1,189 @@ | |||
| # GitHub Actions Skill | |||
There was a problem hiding this comment.
🟠 Important: missing plugin scaffolding — skill won't load in Claude/Codex environments.
Every skill in this repository ships three additional items alongside and . The skill is the only one missing them.
Compare with any peer skill (, , ):
The and files are symlinks pointing to . They let Claude and Codex discover the skill automatically when the repo is cloned locally.
The should contain:
Without this scaffolding the skill loads fine in the OpenHands marketplace, but is invisible to Claude and Codex environments that rely on those dotfile symlinks for auto-discovery.
Description
This PR adds a comprehensive GitHub Actions skill that helps with creating, testing, and debugging GitHub Actions workflows and custom actions.
Closes #55
What's Included
SKILL.md
actghCLI usageREADME.md
marketplace.json
Key Features
✅ Testing Requirements: Clearly explains the requirement to merge actions to main before use
✅ Debug Guidance: Emphasizes adding debug steps that print non-secret parameters
✅ Practical Examples: Code snippets for real-world scenarios
✅ Security Focus: Covers permissions, secrets, and fork PR handling
✅ Comprehensive Coverage: Addresses tricky, non-obvious issues like:
Testing
All existing tests pass:
Related Issue
Implements the feature requested in #55 by @juanmichelini
@juanmichelini can click here to continue refining the PR