Skip to content

chore(release): 0.11.1 - #361

Closed
client-software-ci wants to merge 1 commit into
mainlinefrom
bump/0.11.1
Closed

chore(release): 0.11.1#361
client-software-ci wants to merge 1 commit into
mainlinefrom
bump/0.11.1

Conversation

@client-software-ci

Copy link
Copy Markdown
Collaborator

0.11.1 (2026-08-26)

Features

Bug Fixes

  • drain exit step context before failures (457a364)
  • seed the resolved base into wrap hook scope (457a364)
  • replay a wrap env's own base into hook scope (457a364)
  • type the hook-scope capture stand-in exactly (457a364)

Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
@client-software-ci
client-software-ci requested a review from a team as a code owner August 26, 2026 00:32
@leongdl leongdl closed this Aug 26, 2026
@leongdl
leongdl deleted the bump/0.11.1 branch August 26, 2026 00:36
Comment thread CHANGELOG.md
@@ -1,3 +1,18 @@
## 0.11.1 (2026-08-26)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version regression: 0.11.1 is inserted above the existing 0.12.0 entry, and it drops the breaking change.

The base branch already has a ## 0.12.0 (2026-08-26) section at the top of this file (now line 16). This PR prepends ## 0.11.1 (2026-08-26) above it, which:

  1. Breaks the descending-version ordering of the changelog — 0.11.1 < 0.12.0, so the newest-first invariant no longer holds, and the top-of-file entry is no longer the release being cut. Since tag_format = "{version}" and the latest tag is 0.11.0, tagging 0.11.1 after 0.12.0 notes already exist would also make the tag order and the changelog disagree.

  2. Mislabels a breaking change as a patch release. This new section lists exactly the same commit (457a364) as 0.12.0, but omits 0.12.0s ⚠ BREAKING CHANGES block. That block is real in this tree: extra_let_bindings no longer exists anywhere in src/ (grep -rn extra_let_bindings src/ returns nothing) — it was replaced by resolved_symtab in _session.py:763/:1045 and _v1/_session.py:256/:282/:301. Publishing that removal as 0.11.1 tells downstream consumers a patch bump is safe when it will break any caller passing extra_let_bindings=, which was public in 0.11.0.

If the intent is to release these changes, this should stay 0.12.0 (with the BREAKING CHANGES block) rather than adding a second, lower-versioned section for the same commit. If 0.12.0 was added in error and needs replacing, that section should be removed in this PR rather than shadowed.

Comment thread CHANGELOG.md

### Features
* accept a resolved symbol table on the v0 session (#357) ([`457a364`](https://github.com/OpenJobDescription/openjd-sessions-for-python/commit/457a364371cb44bf5a6253e612a451e5678621d3))
* deliver step-scope let bindings to run_task ([`457a364`](https://github.com/OpenJobDescription/openjd-sessions-for-python/commit/457a364371cb44bf5a6253e612a451e5678621d3))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry advertises an API that does not exist in the released tree. extra_let_bindings was added to run_task and then removed by the same commit range — the 0.12.0 section below (line 25) correctly annotates it with "added extra_let_bindings to run_task, then superseded within this same release; see BREAKING CHANGES above", but that qualifier is dropped here. As written, a reader of 0.11.1 release notes would go looking for an extra_let_bindings parameter on run_task that isn't there.

Relatedly, lines 5 and 7 are the same feature listed twice, differing only in capitalization ("accept a resolved symbol table on the v0 session" / "Accept resolved symbol table on v0 session"), both pointing at commit 457a364. Worth de-duplicating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants