Skip to content

fix: correct upper-Z EXPR conformance fixture #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

fix: correct upper-Z EXPR conformance fixture #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conformance-tests/2023-09/EXPR/job_templates/expr2.2.5--re-backslash-upper-Z.invalid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ steps:
command: python
args:
- -c
- print(r'{{ re_search("hello", r"llo\z") }}')
- print(r'{{ re_search("hello", r"llo\\Z") }}')

@leongdl leongdl Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a single backslash: r"llo\Z". In an EXPR raw string, \\Z is two literal backslashes — as a regex that's an escaped backslash plus a literal Z, which is valid in the dialect, so the fixture no longer tests rejection of the \Z anchor. Compare the lower-z sibling (r"llo\z") and the backreference fixture (r"(a)\1"), which both use single backslashes.