refactor: remove football-related technical debt from codebase - #216
Closed
NicoRuedaA wants to merge 17 commits into
Closed
refactor: remove football-related technical debt from codebase#216NicoRuedaA wants to merge 17 commits into
NicoRuedaA wants to merge 17 commits into
Conversation
Eliminate 52 football remnants from the OFM-to-OLManager migration across 3 phases: critical domain changes, medium i18n/cleanup, low deprecations. Phase A - Critical: - Rename StandingEntry: goals_for/against -> maps_won/lost, kill_difference() - Remove formation from Team (struct + V53 migration) - Remove clean_sheets, footedness, yellow_cards/red_cards, draws - #[deprecated] on Position enum (use LolRole instead) - Replace CompactTeamMatchStatsData with LoL stats - Rewrite SquadTab.helpers.ts: buildPitchRows -> buildLaneRows - PlayStyle -> DraftStrategy (backend + frontend + V54 migration) - Remove football_nation from WorldEditorTab, store types, scripts Phase B - Medium: - Rename i18n keys: footballHerald->lolEsports, pitchInteractionHint->riftInteractionHint - Rename footballTermGuard.ts -> guard.ts - Rename FOOTBALL_IDENTITIES -> LEGACY_NATIONAL_IDENTITIES - Remove openfootlogo.svg references - Migrate test data from 4-4-2 to LoL 5-role rosters Phase C - Low: - Clean up Rust/frontend comments (football -> legacy/LoL) - Remove offsides from test fixtures - Archive migration proposals to docs/legacy/archived-proposals/ - Update lec_world.json description from OpenFootManager to OLManager Fixes: - Add missing locale argument to finish_live_match_internal (blocked game load) Stadium/arena rename excluded by user request.
- Add missing getStandingKillsFor and getStandingKillsAgainst wrappers in types.ts - Fix TournamentsTab test: Fixtures -> Matches (post i18n rename) - Game now loads correctly, all 646 frontend tests pass
- Replace openfootlogo.svg with olmanager-logo.svg - Restore img tag in MainMenu.tsx pointing to new logo - New SVG logo with shield crest + Open League Manager text
Renamed 5 player attributes and removed 3 dead goalkeeper fields: - pace -> reaction_speed - strength -> durability - passing -> coordination - tackling -> interception - defending -> positional_defense - REMOVED: handling, reflexes, aerial (dead code, unused) All renamed fields have #[serde(alias)] for backward compat.
- TeamData: play_style -> draft_strategy - EngineTeamData: play_style -> draft_strategy - LeagueStandingSnapshot: removed drawn, goals_for->maps_won, goals_against->maps_lost - Fixed 80+ test files with outdated field references - Removed draws/drawn/formation from test data
NicoRuedaA
force-pushed
the
chore/remove-football-tech-debt
branch
from
May 8, 2026 14:58
6da2f94 to
e6b6ce9
Compare
Covers Team, Player, and Staff attributes with their in-game effects, usage locations, and multiplier formulas. Includes LolStaffEffects output chain (coaching→8 multipliers) and full match flow diagram.
- Removed deprecated Position enum (17 football variants) and all references - Removed CoachingSpecialization enum (7 variants, 3 unused) and specialization field - Removed shared.rs from engine (dead code: PlayerSnap, TraitContext, DraftStrategyPhase, etc.) - Removed default_engine_attr helper - Updated tests, DB queries, staff effects, and training mappings accordingly
NicoRuedaA
marked this pull request as draft
May 9, 2026 05:32
- Added logo_url: Option<String> to Team struct - Populated from team name slug on world load - Removed FALLBACK_TEAM_LOGOS hardcoded mapping - Renamed resolveExampleTeamLogo → resolveTeamLogo with optional logoUrl param
… paths - Rename lec_world.json to world.json, generate-lec-world.mjs to generate-world.mjs - Rename lec-default to default in Rust and frontend - Add logo_url to each team in world.json (local /teams-icons/slug.webp) - Fix Movistar KOI slug from mad-lions to movistar-koi - Move team shields to public/teams-icons/ as WebP - Remove shifters external lolesports URL (local shield now) - Update Rust fallback path from /team-logos/ to /teams-icons/
…ibutes - Fix Rust world_source check from lec-default to default - Fix attrsFor() to merge 16 old attrs into 9 new LoL attrs - Remove weak_foot from generated player data - Regenerate world.json with 9-attribute format
NicoRuedaA
marked this pull request as ready for review
May 11, 2026 19:33
Contributor
Author
|
@aalonsolopez echale un ojillo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #214
Summary
Removed 52 football-era remnants from the OFM-to-OLManager migration. The refactor spans 4 phases: domain model cleanup, DB schema migration, frontend adaptation, and player attribute renaming.
Changes
Phase A — Critical (Domain + DB + Core Frontend)
positiontoLolRoleacross domain, engine, and frontendfootball_nationfrom team/player seed datastadium_name/stadium_capacity→ renamed toarena_name/arena_capacityPositionenum entirely — now uses unifiedLolRolePhase B — DB Schema + Data Cleanup
Phase C — Frontend + Tests
LolRoleinstead ofPositionPhase D — Player Attributes Renamed (16 → 9 LoL stats)
Test Results
cargo test --workspace: All 500+ Rust tests passnpm test: 646/646 (117 files, 0 failures)84 files changed, 2630 insertions(+), 24334 deletions(-)