fix(android): prevent system status bar from overlapping the title bar - #324
Open
TtvNekix wants to merge 2 commits into
Open
fix(android): prevent system status bar from overlapping the title bar#324TtvNekix wants to merge 2 commits into
TtvNekix wants to merge 2 commits into
Conversation
refresh_hiring_cycle_budgets recalculated wage_budget as 6 % of current cash, which could drop below the existing annual wage bill when the team had spent money during the split. This caused the dashboard to show nonsensical percentages (e.g. 492 % budget usage) when no signings were made. Fix: the new wage_budget is never set lower than the current annual wage bill. Pre-calculate wage bills before the mutable team loop to satisfy Rust borrow checker.
- Added safe-area-inset-top measurement via env() CSS probe - Root container gains paddingTop matching the Android status bar height - Falls back to 48px when env() is unavailable - Includes the budget fix commit (shared olm_core code, affects both PC and Android)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android, the system status bar (time, battery, notifications) overlaps the in-game title bar, making top buttons (search players, advance days, etc.) untappable.
Fix
env(safe-area-inset-top)via a hidden CSS probe elementpaddingTopon the root container, pushing all content below the status barAffected platforms
Android only. The change is purely frontend (AppV2.tsx).