fix: add champion load error state with retry support - #329
Open
TtvNekix wants to merge 1 commit into
Open
Conversation
When the get_champions IPC call fails, the error was silently logged to console. Now it sets championLoadError bool so the UI can detect the failure and re-trigger loading on next effect cycle.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "TypeError: Failed to fetch" error when loading champions.
When the
get_championsIPC call fails, the error was silently logged to console. Now it sets achampionLoadErrorstate that the UI can use to detect the failure and automatically retry on the next effect cycle.Additionally, the error state is tracked so that once champions load successfully, the error clears automatically.