fix: validate opponent roster before starting match and show error - #332
Open
TtvNekix wants to merge 1 commit into
Open
fix: validate opponent roster before starting match and show error#332TtvNekix wants to merge 1 commit into
TtvNekix wants to merge 1 commit into
Conversation
The 'start match' button did nothing when the opponent team was missing players in one or more roles (e.g. no support player). The backend now validates BOTH teams have a full 5-role lineup before creating the match, returning a clear error message when the opponent can't field a team.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "start match" button appeared to do nothing when the opponent team was missing players in one or more roles (e.g. no SUPPORT player for Fnatic).
The backend now validates BOTH teams have a full 5-role lineup (TOP, JUNGLE, MID, ADC, SUPPORT) before creating the live match, returning a clear error message when either side can't field a complete team.