refactor(domain): migrate ManagerCareerStats to LoL (remove draws) - #69
Merged
aalonsolopez merged 4 commits intoMay 1, 2026
Conversation
- Removed draws field from ManagerCareerStats struct (LoL has no draws) - Updated end_of_season.rs to not update draws stat - Updated related tests Refs: #54
NicoRuedaA
force-pushed
the
feat/54-remove-draws-manager-career-stats
branch
from
April 30, 2026 22:42
b2284db to
848571c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drawsfield fromManagerCareerStatsstruct since LoL matches have no drawsend_of_season.rsto remove the line that updatescareer_stats.drawsChanges
manager.rs: Removeddraws: u32from struct definitionend_of_season.rs: Removed update tocareer_stats.drawsend_of_season_tests.rs: Removed test assertion for drawsTesting
cargo checkpassesRefs: #54