Skip to content

refactor(domain): migrate PlayerSeasonStats to LoL terminology - #70

Merged
aalonsolopez merged 4 commits into
OpenLeagueManager:developfrom
NicoRuedaA:feat/52-player-season-stats-lol-terminology
May 1, 2026
Merged

refactor(domain): migrate PlayerSeasonStats to LoL terminology#70
aalonsolopez merged 4 commits into
OpenLeagueManager:developfrom
NicoRuedaA:feat/52-player-season-stats-lol-terminology

Conversation

@NicoRuedaA

Copy link
Copy Markdown
Contributor

Summary

  • Renamed goals field to kills in PlayerSeasonStats struct to use LoL terminology
  • Updated all references across the codebase:
    • end_of_season.rs: Updated to use player.stats.kills when creating career entry
    • post_match.rs: Updated to add kills to player.stats.kills
    • round_summary.rs, news.rs, season_awards.rs: Updated top scorer logic
    • Tests in turn_tests.rs, end_of_season_tests.rs, player_repo.rs

Changes

  • player.rs: Changed goals: u32 to kills: u32 in PlayerSeasonStats struct
  • Updated all code that references stats.goals to use stats.kills

Testing

  • cargo check passes

Refs: #52

aalonsolopez and others added 4 commits April 30, 2026 19:38
0.1.2
Version missmatch
- Renamed goals field to kills in PlayerSeasonStats struct (LoL terminology)
- Updated all references across the codebase
- Updated tests in turn_tests.rs, end_of_season_tests.rs, and player_repo.rs

Refs: #52
@NicoRuedaA
NicoRuedaA force-pushed the feat/52-player-season-stats-lol-terminology branch 2 times, most recently from 41b4cd6 to 53e8321 Compare April 30, 2026 22:47
@aalonsolopez
aalonsolopez changed the base branch from main to develop April 30, 2026 23:22
@aalonsolopez
aalonsolopez merged commit 6e946b8 into OpenLeagueManager:develop May 1, 2026
6 of 8 checks passed
@NicoRuedaA
NicoRuedaA deleted the feat/52-player-season-stats-lol-terminology branch May 7, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants