ci: enable Rust tests and clippy in PR validation - #71
Merged
aalonsolopez merged 4 commits intoMay 1, 2026
Conversation
Add cargo clippy and cargo test to the rust-check job that runs on every pull request. Tests are set to continue-on-error since there are pre-existing test failures in lol_sim_v2 that need to be fixed separately. Closes #60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --workspace --all-targets -- -D warningsto the PR validation workflowcargo test --workspaceto the PR validation workflow (withcontinue-on-errordue to pre-existing test failures)Why
The
rust-checkjob previously only rancargo fmt --checkandcargo check --workspace. This PR enables:Tests are set to
continue-on-error: truebecause there are 14 pre-existing test failures inlol_sim_v2that need to be fixed separately. Once those are resolved, the flag can be removed.Scope
.github/workflows/pr.yml- 7 lines added torust-checkjobChecklist
-D warnings)Closes #60