refactor(domain): migrate football_nation to nationality_code + competitive_region - #75
Merged
aalonsolopez merged 4 commits intoMay 1, 2026
Conversation
…titive_region Rename football_nation field to nationality_code across all domain structs (Player, Team, Manager, Staff) and add competitive_region field for LoL regional classification. Closes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the domain layer to migrate from
football_nationtonationality_code+competitive_regionfor better LoL alignment.Changes
football_nationfield tonationality_codeacross all domain structs (Player, Team, Manager, Staff)competitive_regionfield (String, default empty "") to each domain struct for LoL regional classificationMotivation
The
football_nationfield was a legacy from the football-themed version. Since this is now a LoL-focused manager game, we should use more appropriate terminology. Thenationality_codemaintains the ISO country code functionality, whilecompetitive_regionallows classification of teams/players into LoL regions (e.g., LCK, LEC, LCS, etc.).Closes #49