refactor(domain): replace Position enum with LolRole - #80
Merged
aalonsolopez merged 2 commits intoMay 1, 2026
Merged
Conversation
- Remove 19-variant Position enum (football positions) - Use existing 5-variant LolRole enum (Top, Jungle, Mid, Adc, Support) - Implement custom Deserialize for backward compatibility with legacy Position strings - Update 45+ files across domain, engine, ofm_core, db, and frontend - Add 5 role-specific rating weight maps - Update TypeScript types and components Closes #50
NicoRuedaA
force-pushed
the
feat/50-position-to-lol-role
branch
from
May 1, 2026 10:03
400360b to
73b8381
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Type
Summary
Test Plan
Closes #50