refactor(domain): migrate PlayerAttributes to LoL stats - #82
Closed
NicoRuedaA wants to merge 1 commit into
Closed
Conversation
- Replace 19 football attributes with 9 LoL stats (mechanics, laning, teamfighting, macro_play, consistency, shotcalling, champion_pool, discipline, mental_resilience) - Custom Deserialize with serde aliases for backward compatibility - Update player.rs with new struct and OVR calculation - Update TypeScript types and components - Update training and scouting systems - Full SDD artifacts in docs/propose/62-player-attributes-to-lol-stats/ Closes #62
Contributor
Author
|
Re-cerrando PR #82: El cambio requiere actualizar ~345 lugares en el código donde se usa PlayerAttributes. Es un cambio muy complejo que necesita una refactorización manual cuidadosa. Recomendación: hacer este cambio en múltiples PRs más pequeños, o mantener los campos de fútbol con aliases hacia LoL para backward compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Type
Summary
Closes #62