feat: audit invoice nft contracts with tests and docs#159
Open
mgtmdccix-oss wants to merge 1 commit into
Open
Conversation
- Remove artificial i128::MAX/2 amount cap that rejected valid large amounts - Fix missing invoice_funded event emission in set_funded - Add missing require_not_paused check to set_repaid for consistency - Remove dead code: unused old_status variables in set_funded and set_repaid - Add TTL extension (bump_invoice_ttl) on every persistent invoice write to prevent storage expiry per ARCHITECTURE.md guidance - Initialize InvoiceCount to 0 explicitly in initialize() - Document require_not_paused stub with v1/v2 cross-contract integration notes - Remove duplicate test functions (merge artifact) - Expand test suite: specific KoraError variant assertions, new edge case tests for due_date == now, defaulted at exact due_date, wrong-status defaulted, large amounts, invoice count tracking, core field immutability, and all four risk tier boundary transitions as individual test cases
|
@mgtmdccix-oss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes Audit Invoice NFT Contracts #102