Skip to content

fix: resolve issues #138, #137, #136, #25#160

Open
thelux134 wants to merge 1 commit into
OpenLedger-Foundation:mainfrom
thelux134:fix/issue-138-137-136-25
Open

fix: resolve issues #138, #137, #136, #25#160
thelux134 wants to merge 1 commit into
OpenLedger-Foundation:mainfrom
thelux134:fix/issue-138-137-136-25

Conversation

@thelux134
Copy link
Copy Markdown

#138 - Treasury reentrancy guard:

  • Remove local ReentrancyGuard struct; use kora_shared::reentrancy::ReentrancyGuard
  • Fix emergency_withdraw double-transfer bug (was calling transfer twice)
  • Replace manual acquire_lock/release_lock with RAII guard in both withdraw and emergency_withdraw
  • Add missing WhitelistedToken variant to DataKey enum

#137 - Standardize Risk Registry events:

  • Add registry_initialized event to shared events module
  • Emit registry_initialized from RiskRegistryContract::initialize()
  • All other operations already used shared events consistently

#136 - Shared Contracts Library:

  • Remove duplicate ReentrancyGuard struct definition in reentrancy.rs
  • Single canonical RAII guard with acquire_guard/release_guard/is_locked helpers

#25 - Invoice NFT documentation:

, OpenLedger-Foundation#136, OpenLedger-Foundation#25

OpenLedger-Foundation#138 - Treasury reentrancy guard:
- Remove local ReentrancyGuard struct; use kora_shared::reentrancy::ReentrancyGuard
- Fix emergency_withdraw double-transfer bug (was calling transfer twice)
- Replace manual acquire_lock/release_lock with RAII guard in both withdraw and emergency_withdraw
- Add missing WhitelistedToken variant to DataKey enum

OpenLedger-Foundation#137 - Standardize Risk Registry events:
- Add registry_initialized event to shared events module
- Emit registry_initialized from RiskRegistryContract::initialize()
- All other operations already used shared events consistently

OpenLedger-Foundation#136 - Shared Contracts Library:
- Remove duplicate ReentrancyGuard struct definition in reentrancy.rs
- Single canonical RAII guard with acquire_guard/release_guard/is_locked helpers

OpenLedger-Foundation#25 - Invoice NFT documentation:
- Add MigrationVersion variant to DataKey enum (was used in code but undeclared)
- Update DataKey doc comment to list all variants including MigrationVersion
- Remove stale InvoiceCount reference from storage key comment block
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 1, 2026

@thelux134 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant