fix: resolve issues #138, #137, #136, #25#160
Open
thelux134 wants to merge 1 commit into
Open
Conversation
, OpenLedger-Foundation#136, OpenLedger-Foundation#25 OpenLedger-Foundation#138 - Treasury reentrancy guard: - Remove local ReentrancyGuard struct; use kora_shared::reentrancy::ReentrancyGuard - Fix emergency_withdraw double-transfer bug (was calling transfer twice) - Replace manual acquire_lock/release_lock with RAII guard in both withdraw and emergency_withdraw - Add missing WhitelistedToken variant to DataKey enum OpenLedger-Foundation#137 - Standardize Risk Registry events: - Add registry_initialized event to shared events module - Emit registry_initialized from RiskRegistryContract::initialize() - All other operations already used shared events consistently OpenLedger-Foundation#136 - Shared Contracts Library: - Remove duplicate ReentrancyGuard struct definition in reentrancy.rs - Single canonical RAII guard with acquire_guard/release_guard/is_locked helpers OpenLedger-Foundation#25 - Invoice NFT documentation: - Add MigrationVersion variant to DataKey enum (was used in code but undeclared) - Update DataKey doc comment to list all variants including MigrationVersion - Remove stale InvoiceCount reference from storage key comment block
|
@thelux134 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#138 - Treasury reentrancy guard:
#137 - Standardize Risk Registry events:
#136 - Shared Contracts Library:
#25 - Invoice NFT documentation:
Closes Fix Reentrancy Guard in Treasury Contracts #138
closes Standardize Events in Risk Registry Contracts #137
closes Implement Shared Contracts Library #136
closes Update Documentation for Invoice NFT Contracts #25