fix: resolve issues #120 #121 #122 #123#165
Open
icentedward76-sketch wants to merge 1 commit into
Open
Conversation
OpenLedger-Foundation#122 OpenLedger-Foundation#123 OpenLedger-Foundation#120/OpenLedger-Foundation#121 - Enhance/implement shared contracts library: - Fix duplicate ReentrancyGuard struct in reentrancy.rs - Clean up lib.rs to only contain module declarations OpenLedger-Foundation#122 - Migrate state variables in risk registry: - Migrate Admin and InvoiceNft from instance() to persistent() storage - Add TTL bumping for Admin and InvoiceNft keys on write OpenLedger-Foundation#123 - Refactor treasury contracts: - Add missing WhitelistedToken variant to DataKey enum - Add missing imports: ReentrancyGuard, require_non_zero_amount - Remove undefined acquire_lock/release_lock helpers - Replace manual lock with RAII ReentrancyGuard in withdraw/emergency_withdraw - Fix double token transfer in emergency_withdraw - Add bump_persistent helper for consistent TTL management
|
@icentedward76-sketch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#120/#121 - Enhance/implement shared contracts library:
#122 - Migrate state variables in risk registry:
#123 - Refactor treasury contracts:
Closes Enhance Security of Shared Contracts Library #120
closes Implement Shared Contracts Library #121
closes Migrate State Variables in Risk Registry Contracts #122
closes Refactor Treasury Contracts #123