Skip to content

fix(PackageDownload): join base path with streamSaver.mitm#562

Merged
xrgzs merged 1 commit into
mainfrom
fix/packagedown
Jun 26, 2026
Merged

fix(PackageDownload): join base path with streamSaver.mitm#562
xrgzs merged 1 commit into
mainfrom
fix/packagedown

Conversation

@xrgzs

@xrgzs xrgzs commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary / 摘要

根因分析

PackageDownload.tsx 中 streamSaver.mitm 被硬编码为 /streamer/mitm.html,没有考虑应用的 base path。

当应用部署在子路径下(如 /ls/)时:

  1. 浏览器请求 /streamer/mitm.html → 服务器返回 SPA 的 index.html(HTML 内容)
  2. index.js:1 Uncaught SyntaxError: Unexpected token '<' — HTML 被当作 JS 解析
  3. Service Worker 注册失败 → StreamSaver 无法建立流式下载通道
  4. 第一个文件下载完成后流管道断裂 → 卡住不动

修改内容

文件: PackageDownload.tsx

  1. 修复 mitm 路径"/streamer/mitm.html"joinBase("streamer", "mitm.html"),确保在任何 base path 下都能正确加载 mitm.html 并注册 Service Worker。

  2. 添加 fetch 错误处理:在 pull 函数中检查 res.ok,当文件下载返回非 200 响应(如 500)时抛出明确错误,而不是将错误响应体作为文件内容写入 zip,导致后续文件无法处理。错误会被 pipeTo.catch 捕获并显示在 UI 上。

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList:
  • OpenList-Docs:

Related Issues / 关联 Issue

Closes #341

Testing / 测试

  • go test ./...
  • Manual test / 手动测试:
image

因跨域问题导致的下载失败不在考虑范围之内。

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmtgo fmtprettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

…quests

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
@xrgzs xrgzs added the bug Something isn't working label Jun 26, 2026
@xrgzs xrgzs merged commit 2d52742 into main Jun 26, 2026
1 check passed
@xrgzs xrgzs deleted the fix/packagedown branch June 26, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 打包下载报错

2 participants