fix(PackageDownload): join base path with streamSaver.mitm#562
Merged
Conversation
…quests Co-authored-by: Copilot <copilot@github.com> Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
jyxjjj
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
根因分析
PackageDownload.tsx 中
streamSaver.mitm被硬编码为/streamer/mitm.html,没有考虑应用的 base path。当应用部署在子路径下(如
/ls/)时:/streamer/mitm.html→ 服务器返回 SPA 的 index.html(HTML 内容)index.js:1 Uncaught SyntaxError: Unexpected token '<'— HTML 被当作 JS 解析修改内容
文件: PackageDownload.tsx
修复 mitm 路径:
"/streamer/mitm.html"→joinBase("streamer", "mitm.html"),确保在任何 base path 下都能正确加载 mitm.html 并注册 Service Worker。添加 fetch 错误处理:在
pull函数中检查res.ok,当文件下载返回非 200 响应(如 500)时抛出明确错误,而不是将错误响应体作为文件内容写入 zip,导致后续文件无法处理。错误会被pipeTo的.catch捕获并显示在 UI 上。/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Closes #341
Testing / 测试
go test ./...因跨域问题导致的下载失败不在考虑范围之内。
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。