refactor: introduce EditControlFactory and use BaseOpticalElementView in _setupView - #10
Merged
Merged
Conversation
… in _setupView EditContainerNode previously imported 14 concrete model classes and contained a 580-line instanceof chain (_buildControls). This is moved into a new EditControlFactory.ts — the intentional single coupling point between model classes and their edit-panel controls, mirroring OpticalElementViewFactory. EditContainerNode now has zero direct model-class imports; it delegates to buildEditControls() and uses the returned refreshCallback. SimScreenView._setupView had a 7-branch instanceof chain where every branch assigned the same onRebuild callback. Replaced with a single instanceof BaseOpticalElementView check, which is correct by construction since all concrete views extend that base class. https://claude.ai/code/session_012UtbyBmcxQsUwyQuWza6D8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditContainerNode previously imported 14 concrete model classes and contained
a 580-line instanceof chain (_buildControls). This is moved into a new
EditControlFactory.ts — the intentional single coupling point between model
classes and their edit-panel controls, mirroring OpticalElementViewFactory.
EditContainerNode now has zero direct model-class imports; it delegates to
buildEditControls() and uses the returned refreshCallback.
SimScreenView._setupView had a 7-branch instanceof chain where every branch
assigned the same onRebuild callback. Replaced with a single
instanceof BaseOpticalElementView check, which is correct by construction
since all concrete views extend that base class.
https://claude.ai/code/session_012UtbyBmcxQsUwyQuWza6D8