chore: update package-lock.json peer dependency flags - #17
Merged
Merged
Conversation
Auto-generated by npm install during session startup. https://claude.ai/code/session_01JLmgyezwDr8dgC5hq9fMX6
Introduce ElementRegistry.ts as a single source of truth that maps each
optical element class to its view constructor and edit-controls builder.
OpticalElementViewFactory and EditControlFactory now delegate to this
registry, so adding a new element type only requires one registry entry
instead of updating three separate dispatch chains.
Break up the two large view files:
- Extract all 825-line icon-builder block from ComponentCarousel.ts into
carousel/CarouselIcons.ts, reducing ComponentCarousel from 1363 → 340 lines
- Split EditControlFactory.ts (997 lines) into per-family modules:
edit-controls/LightSourceEditControls.ts
edit-controls/GlassEditControls.ts
edit-controls/MirrorEditControls.ts
edit-controls/EditControlHelpers.ts (shared widget factories)
edit-controls/EditControlsResult.ts (shared result type)
EditControlFactory is now a 35-line thin dispatcher
- OpticalElementViewFactory is now a 25-line thin wrapper
https://claude.ai/code/session_01JLmgyezwDr8dgC5hq9fMX6
EditControlFactory and OpticalElementViewFactory re-export types (EditControlsResult, OpticalElementView) for backward compatibility. TypeScript requires those types to be in scope locally for use in function return-type annotations, so add the matching import type statements alongside the export-from re-exports. https://claude.ai/code/session_01JLmgyezwDr8dgC5hq9fMX6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated by npm install during session startup.
https://claude.ai/code/session_01JLmgyezwDr8dgC5hq9fMX6