Hoist hardcoded colors and strings to OpticsLabColors and i18n - #18
Merged
Merged
Conversation
- Add blockerFillProperty, glassBorderStrokeProperty, measuringTapeTextColorProperty, measuringTapeBackgroundColorProperty, wavelengthThumbStrokeProperty, and halfPlaneGlassFill() to OpticsLabColors.ts so all colours are profile-aware. - CircleBlockerView: use OpticsLabColors.blockerFillProperty / blockerBackStrokeProperty instead of local constants. - CircleGlassView: use OpticsLabColors.glassFillProperty / glassStrokeProperty (same values already defined there). - HalfPlaneGlassView: use OpticsLabColors.glassBorderStrokeProperty and the new halfPlaneGlassFill() helper. - SymmetricWavelengthThumb: use OpticsLabColors.wavelengthThumbStrokeProperty. - EditControlHelpers: use OpticsLabColors.overlayInputBackgroundProperty / overlayInputBorderProperty (matching values already in colors file); use i18n wavelengthStringProperty for the λ label. - SimScreenView: use OpticsLabColors for measuring tape text/background colours; use i18n metersUnitStringProperty for the unit name. - Add ui.metersUnit and controls.wavelength to strings_en.json and strings_fr.json; expose them through StringManager. https://claude.ai/code/session_01LazmDycdJFcxjWRsS49ibG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
measuringTapeTextColorProperty, measuringTapeBackgroundColorProperty,
wavelengthThumbStrokeProperty, and halfPlaneGlassFill() to
OpticsLabColors.ts so all colours are profile-aware.
blockerBackStrokeProperty instead of local constants.
glassStrokeProperty (same values already defined there).
and the new halfPlaneGlassFill() helper.
overlayInputBorderProperty (matching values already in colors file);
use i18n wavelengthStringProperty for the λ label.
colours; use i18n metersUnitStringProperty for the unit name.
strings_fr.json; expose them through StringManager.
https://claude.ai/code/session_01LazmDycdJFcxjWRsS49ibG