feat: render point/arc source rays as continuous filled regions at high density - #19
Merged
Merged
Conversation
…gh density When ray density exceeds a threshold (0.8), rays from PointSourceElement and ArcLightSource are rendered as filled polygons between adjacent rays instead of individual lines. This produces a smooth continuous beam appearance that extends through all optical interactions (reflections, refractions, diffraction). A proximity check on segment endpoints prevents incorrect filling between divergent ray paths. https://claude.ai/code/session_01DpSEWjiYmCQCBJG4ZDWaMB
Split the monolithic paintContinuousRays method into smaller functions (groupSegmentsBySource, isQuadOutside, fillBetweenChains) to satisfy the linter's cognitive complexity limit and remove non-null assertions. https://claude.ai/code/session_01DpSEWjiYmCQCBJG4ZDWaMB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ray density exceeds a threshold (0.8), rays from PointSourceElement
and ArcLightSource are rendered as filled polygons between adjacent rays
instead of individual lines. This produces a smooth continuous beam
appearance that extends through all optical interactions (reflections,
refractions, diffraction). A proximity check on segment endpoints
prevents incorrect filling between divergent ray paths.
https://claude.ai/code/session_01DpSEWjiYmCQCBJG4ZDWaMB