Schema 49#456
Merged
Merged
Conversation
b-s-code
reviewed
Jun 9, 2026
b-s-code
left a comment
b-s-code
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, only suggestion is adding a Dockerfile for v49.
b-s-code
reviewed
Jun 12, 2026
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| build-essential ca-certificates git libz-dev python3 cmake libgsl-dev libxerces-c-dev xsdcxx libboost-dev \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && git clone --depth 1 --branch ${OM_BRANCH} https://github.com/SwissTPH/openmalaria.git \ |
Collaborator
There was a problem hiding this comment.
I imagine this works fine but would be worth updating SwissTPH to OpenMalaria-Org.
b-s-code
reviewed
Jun 18, 2026
b-s-code
left a comment
b-s-code
left a comment
Collaborator
There was a problem hiding this comment.
The decision to update many URLs is a good one. I found a couple links that broke with the find and replace (openmalaria.tools repo) but otherwise looks good.
Comment on lines
+686
to
+687
| w.p('[generateDoc.py](https://github.com/OpenMalaria-Org/openmalaria.tools/blob/master/openmalaria/tools/generateDoc.py),') | ||
| w.p(', found in the [openmalaria.tools repository](https://github.com/OpenMalaria-Org/openmalaria.tools).') |
Collaborator
There was a problem hiding this comment.
We still want SwissTPH for these URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version number increased to 49
<option name="USE_EXACT_NV0_SOLVER" value="true"/>to example_scenario.xml to enable the new emergence rate calculation for new users while keeping the old method as the default