Skip to content

cmake: improve install prefix handling and clarity #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
venkata-p2498 wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −2
Open

cmake: improve install prefix handling and clarity #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c5a822
Fix build failures: document missing dependencies and submodule initi…
venkata-p2498 May 5, 2026
dd3c5f0
cmake: use current source dir for install prefix and clarify logic
venkata-p2498 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ cmake_minimum_required (VERSION 3.23.1)
project(openmoonray)

list(APPEND CMAKE_MESSAGE_CONTEXT ${PROJECT_NAME})
if(NOT DEFINED CMAKE_INSTALL_PREFIX OR ${CMAKE_INSTALL_PREFIX} STREQUAL "/usr/local")
set(CMAKE_INSTALL_PREFIX ${CMAKE_SOURCE_DIR}/release)
# Set default install prefix to local release directory if not explicitly provided
# or if default system path (/usr/local) is being used.
if(NOT DEFINED CMAKE_INSTALL_PREFIX OR CMAKE_INSTALL_PREFIX STREQUAL "/usr/local")
set(CMAKE_INSTALL_PREFIX "${CMAKE_CURRENT_SOURCE_DIR}/release")
endif()
list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules/cmake)
list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/rats/cmake)
Expand Down
18 changes: 18 additions & 0 deletions docs/build-troubleshooting.md
View file
Open in desktop

@jlanz jlanz Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @venkata-p2498 - we may want to split this file out into a separate PR.
I do like the idea of starting a build-troubleshooting doc, but we may want to put some thought into how best to organize the docs/ sections. This is a nice start!

We might also want to consider how a troubleshooting guide can be made to account for the different experiences people may encounter in trying to build.

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Build Troubleshooting

## Common Errors

### Missing submodules
Fix:
git submodule update --init --recursive

### Missing dependencies
Install:
- libtbb-dev
- libjsoncpp-dev
- libopenexr-dev

### TBB not found (modern systems)
Use:
-DCMAKE_PREFIX_PATH=/usr/lib/x86_64-linux-gnu/cmake