Implement command line interface for OpenOrienteering Mapper#2523
Open
mfbehrens wants to merge 10 commits into
Open
Implement command line interface for OpenOrienteering Mapper#2523mfbehrens wants to merge 10 commits into
mfbehrens wants to merge 10 commits into
Conversation
Why is there not .clang-format :(
b4e0edd to
e3702b2
Compare
- QPA_PLATFORM on Linux - include `core/map_printer.h` for Android build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2345
I am glad to receive some feedback.
Its been some time that I worked on QT projects 😅
Tiny Documentation
Documentation yet to come but this is a overview:
Early documentation: OpenOrienteering/mapper-manual#79
Other cli designs
I was thinking about using another propsed format
Mapper mymap.omap --cli export -o mymap.pdfThis approach is ugly to handle.
What happens if the user provides multiple inputs at once?
What if you have a command does not receive an input file?
Or what if it needs to receive two?
What kind of backwards compatibility does this give you? (none because there is no previous cli)
Also a very unusual cli design in general, when you compare it to any other clis (at least on gnu/linux)
In the end it does not really change anything except for you not beeing able to open a file called
--cli(however, I am not really sure if this was possible before and you should probably give your file a better name)Known issues
.omapand.xmapare currently not an output format but it is simply decided by their file extension what happens to the outputMapper --cli convert --helpdisplays wrong application name--clihas to be placed as first argument -> qt args like -platform cannot be setPlease squash merge this