Conversation
Co-authored-by: alexlib <747110+alexlib@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds .github/copilot-instructions.md to provide structured context about the easySBA Python bindings repository for GitHub Copilot. The instructions document repository layout, build requirements, testing procedures, coding conventions, and key files to help Copilot assist more accurately with code generation and review tasks.
Changes:
- Added comprehensive Copilot instructions file documenting repository structure, build/test procedures, and coding conventions
- Included a key files reference table mapping important source files to their purposes
- Documented the EASYSBA_RUN_SOLVER environment variable requirement for solver tests
|
|
||
| - Python code follows standard PEP 8 conventions. | ||
| - C/C++ code in `src/` and `easysba/_easysba.cpp` follows the style of the existing sources. | ||
| - Tests live in `tests/` and use `unittest.TestCase` classes, discovered and run via `pytest`. |
There was a problem hiding this comment.
The statement "Tests live in tests/ and use unittest.TestCase classes" is not entirely accurate. While test_smoke.py uses unittest.TestCase, test_sba_steps.py uses plain pytest functions with pytest decorators like @pytest.mark.parametrize. Consider updating this to reflect both testing styles: "Tests live in tests/ and use either unittest.TestCase classes or plain pytest functions, discovered and run via pytest."
| - Tests live in `tests/` and use `unittest.TestCase` classes, discovered and run via `pytest`. | |
| - Tests live in `tests/` and use either `unittest.TestCase` classes or plain pytest functions, discovered and run via `pytest`. |
Adds
.github/copilot-instructions.mdto give GitHub Copilot structured context about this repository so it can assist more accurately.What's included
src/,easysba/,tests/, and config files to their rolespytestinvocation and theEASYSBA_RUN_SOLVER=1flag required to run the solver testsunittest.TestCase+ pytest discoveryWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
gh.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.