Make MaterialPackage uuid optional#21
Merged
Merged
Conversation
GTINs cannot be reliably sourced for all brands, so UUID derivation (which depends on brand UUID + GTIN) is not always possible. Remove uuid from the required fields so material packages without GTINs can be added to the database without a UUID.
Contributor
|
Hmm, if a package doesn't have an UUID, how would you want to reference it from outside the DB? I'm thinking whether it wouldn't be more practical to just assign it a randomly generated UUID in this case. We were hinting a multi-UUID support some time ago. I am not sure myself though atm, would probably welcome a bit of a discussion |
Contributor
|
Okay, seems like I've forgotten about the contents of the talk already, sorry |
CZDanol
approved these changes
Apr 21, 2026
ondratu
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTINs cannot be reliably sourced for all brands, so UUID derivation (which depends on brand UUID + GTIN) is not always possible. Remove uuid from the required fields so material packages without GTINs can be added to the database without a UUID.
https://prusa3d.slack.com/archives/C08K3FW5X8A/p1769500810184589