Rename MaterialType to FFFMaterialType, add FFFMaterial subtype#30
Open
sarkafa wants to merge 1 commit into
Open
Rename MaterialType to FFFMaterialType, add FFFMaterial subtype#30sarkafa wants to merge 1 commit into
sarkafa wants to merge 1 commit into
Conversation
CZDanol
previously approved these changes
Jun 10, 2026
| generate_schema_file("material_type", entity_schema(entity_yaml(materials_yaml, "MaterialType"))) | ||
| generate_schema_file( | ||
| "fff_material", | ||
| entity_schema(entity_yaml(materials_yaml, "FFFMaterial"), include_inherits=False), |
Contributor
There was a problem hiding this comment.
nitpick: technically speaking, include_inherits = True would possibly be marginally safer if fff_material was referenced standalone somewhere. But possibly doesn't matter.
Author
There was a problem hiding this comment.
other fff_/sla_ schemas are also diffs over their parent, so keeping fff_material as a diff seem more consistent with the rest to me
sarkafa
force-pushed
the
split-material-type-fff
branch
from
3c2ed36 to
81a6d2c
Compare
sarkafa
force-pushed
the
split-material-type-fff
branch
from
81a6d2c to
ccdc426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.