Update recommendations for CBOR container types#145
Merged
CZDanol merged 1 commit intoJun 15, 2026
Conversation
CZDanol
reviewed
Jun 15, 2026
Collaborator
|
The reasoning to reduce the indefinite requirement to only aux region sounds reasonable to me - no objections on this point. |
… is excessive. The intent of use of CBOR indefinite containers is to facilitate updates to the tag on a block-centric basis without the necessity to re-write the entire tag for each change. As such, this recommendation only really applies for the AUX container root map with extremely limited potential utility in other situations and the cost of (typically) one extra byte of memory being wasted per container. Update specification to recommend indefinite container use only for the AUX root map.
cjbearman
force-pushed
the
cbor-container-type-adjustment
branch
from
355cc4b to
51d78d2
Compare
CZDanol
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #144
Current recommendation to use indefinite form for all CBOR containers is excessive.
The intent of use of CBOR indefinite containers is to facilitate updates to the tag on a block-centric basis without the necessity to re-write the entire tag for each change.
As such, this recommendation only really applies for the AUX container root map with extremely limited potential utility in other situations and the cost of (typically) one extra byte of memory being wasted per container.
Update specification to recommend indefinite container use only for the AUX root map.