Skip to content

Remove the retired workflow.test_quality_review key from .ground-control.yaml #103

Open

Description

@doublewhy

Problem

.ground-control.yaml on dev (0272949) still declares workflow.test_quality_review.pre_push_cap: 1 (lines 13-14). The file was last changed in f05ef0c (2026-08-02), before Ground Control retired that key.

The reference configuration, OpenRAE/rae's .ground-control.yaml on dev, no longer has it. Three sibling repositories removed it:

env-packs keeps it out with tests/test_ground_control_review_config.py::ReviewConfigPlacementTests::test_retired_test_quality_review_key_is_absent, whose message reads "Ground Control retired workflow.test_quality_review; keeping it makes .ground-control.yaml invalid".

Apart from this key, adapters' codex_review and review_disposition settings already match rae's dev.

Scope

  • Delete the test_quality_review block from workflow: in .ground-control.yaml.
  • Leave codex_review.pre_push_cap: 1, review_disposition and every other key unchanged.

Done when

  • .ground-control.yaml on dev has no workflow.test_quality_review key.
  • Its workflow.codex_review and workflow.review_disposition blocks equal OpenRAE/rae's on dev.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions