Skip to content

fix(kits): keep SMTP/IMAP mailbox addresses consistent with mail_domain #435

Closed

Description

@Brad-Edwards

Problem

The SMTP/IMAP kit accepts a different mail_domain, but its two mailbox addresses remain hard-coded to environment.test. Both mailboxes refer to primary_domain, whose name is the substituted parameter. The published variation therefore produces an inconsistent mail inventory.

This predates PR #433: it exists in the 1.0.0 release and is retained by the proposed 2.0.0 release at head 1a551321c00fa36e0e50674639ad214929a4ef2d.

Reproduction

  1. Compose infrastructure.smtp-imap-mail-service with its tests/composition.yaml variation, which sets mail_domain: alternate.test.
  2. Parse the composition through the pinned raes==6.0.1.
  3. Inspect nodes.<namespace>.mail.runtime.mail_services.

Actual:

  • domains[0].domain_id: primary_domain, domains[0].name: alternate.test.
  • operator_mailbox.address: operator@environment.test, domain_ref: primary_domain.
  • service_mailbox.address: service@environment.test, domain_ref: primary_domain.

Expected:

  • operator@alternate.test and service@alternate.test, consistently referring to the selected domain.
  • The default composition continues to produce the two @environment.test addresses.

Affected content: kits/infrastructure.smtp-imap-mail-service/1.0.0/module.sdl.yaml and the proposed 2.0.0/module.sdl.yaml, plus their parameter-variation coverage.

Scope and ownership

Correct the kit's mailbox/domain relationship using RAES-owned parameter and realization semantics. Do not introduce pack-specific interpolation or extend SDL semantics here.

PR #433 reports that simply substituting operator@${mail_domain} and service@${mail_domain} reintroduces realization.authority-bound-unavailable under RAES 6.0.1. A fix must preserve bounded planning authority; if the current RAES contract cannot express the dependency, file and link a concrete upstream OpenRAE/rae issue before implementing the kit change.

Published releases remain immutable: ship corrected content in a new kit release.

Acceptance criteria

  • Every accepted mail-domain value produces mailbox addresses consistent with the referenced domain.
  • Regression coverage checks both the default and alternate-domain compositions, including the actual composed addresses and domain references.
  • The correction does not reintroduce realization.authority-bound-unavailable.
  • Any necessary upstream contract fix is separately tracked and linked; this repository continues to consume RAES semantics.
  • The corrected release passes kit integrity, composition, and release checks.

Related

Activity

  1. added
    bugSomething isn't working
    in-progressAn agent is actively working this issue via /implement
    on Oct 10, 2026
  2. Brad-Edwards commented on Oct 15, 2026

    @Brad-Edwards
    CollaboratorAuthor

    🛠️ Picked up by /quickfix - driver claude, branch 435-smtp-imap-mailbox-domain, 2026-10-15T05:02:52.887Z.

  3. Brad-Edwards commented on Oct 15, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Pre-PR base synchronization

    • Source: refs/remotes/origin/dev at 5c585f7768e2e47c19c8acf1406d228ce7ff9dee
    • Outcome: merged_clean
    • Published feature head: 3ca81006ccb549458758079a933619082d73f271
    • Synchronized tree: 7c5b79da1ce6615d9ca2b7fa92cafd05acb06bbe
  4. Brad-Edwards commented on Oct 15, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Delivery readiness recorded — Phase E finalizes issue #435 automatically when PR #474 merges.

  5. github-actions commented on Oct 15, 2026

    @github-actions
    Contributor

    Quickfix close — issue #435 complete

    PR: #474

    New SMTP/IMAP kit release 1.2.0 derives mailbox addresses from mail_domain, with regression coverage.

    Files changed

    Added:

    • kits/infrastructure.smtp-imap-mail-service/1.2.0/README.md
    • kits/infrastructure.smtp-imap-mail-service/1.2.0/assets/integration.md
    • kits/infrastructure.smtp-imap-mail-service/1.2.0/assets/seed.yaml
    • kits/infrastructure.smtp-imap-mail-service/1.2.0/associated-artifacts.json
    • kits/infrastructure.smtp-imap-mail-service/1.2.0/kit.yaml
    • kits/infrastructure.smtp-imap-mail-service/1.2.0/module.sdl.yaml
    • kits/infrastructure.smtp-imap-mail-service/1.2.0/tests/composition.yaml
    • tests/test_smtp_imap_mailbox_domain.py

    Modified:

    • tests/test_published_kits.py

    Status

    • CI: ✅ green
    • SonarCloud: ✅ passed
    • PR ready for user review and merge.
  6. removed
    in-progressAn agent is actively working this issue via /implement
    on Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions