Repository navigation
fix: chain TechVault Suricata Wazuh rules off built-in parents - #418
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TechVault Wazuh rule
303020("Web attack (network)") never fired. Rule303000declared a rivaldecoded_as jsonparent. Wazuh binds each JSON event to one decoded_as parent, and the built-in86600always won, so every Suricata alert stopped at generic86601. Each custom rule now chains off the built-in rule for its event type. The pack validator now rejects the broken chain, which it did not detect before.Requirement UIDs
Related Issues
Closes #417
ADR Impact
Changes
303000. Chain alert refinements303001–303060off built-in86601, DNS303110off built-in86603, and flow303100off base86600. Both pack copies stay byte-identical.validate_techvault.pycopies with a bounded parent-topology check. It rejects malformed XML, DTD and entity declarations, duplicate IDs, anydecoded_as, unknown rules, and wrong parents.exact_artifactdigest, the bindings, and the set digests in both packs.docs/lineage.mdfiles and the Suricata content design note.Test Plan
Targeted:
tests.test_techvault_packandtests.test_techvault_study_pack(68 tests) pass.raes-pack-validate --repo .,raes-pack-validate --packs-root packs, andraes-pack-release check --packs-root packspass. Before the validator change, 8 new mutation cases failed. Native proof withwazuh-logtestinwazuh/wazuh-manager:4.12.0: a SID1000010web-application-attack EVE alert selects86601level 3 with the pre-fix file and303020level 10 with the fixed file. Flow selects303100, and DNS selects303110.Ground Control Checks
Traceability
Checklist
Documentation
Updated: see diff.