Skip to content

fix: join main's release history into dev so promotions merge cleanly #1375

Closed

Description

@Brad-Edwards

Bug

The dev → main promotion #1374 conflicts in pyproject.toml and uv.lock.

The release-please back-merge PRs are squash-merged. For example, #1366 (chore: back-merge v7.0.0 into dev) has one parent. So the release commits on main never become ancestors of dev; the last real merge of main into dev was #656. Each promotion replays the release commit's version edit against dev. #1373 changed the adjacent name line to lilrae, so the two edits now conflict.

Fix

  • Merge origin/main into a branch from dev and resolve the conflict: name = "lilrae", version = "7.0.0", and the matching uv.lock entry.
  • Merge that PR into dev with a merge commit, not a squash, so main becomes an ancestor of dev.
  • In docs/releasing.md and the back-merge PR body, say that the back-merge uses a merge commit.

Acceptance criteria

  • origin/main is an ancestor of origin/dev.
  • chore: promote dev to main #1374 shows no merge conflict.
  • The release guide and the automated back-merge PR body tell the maintainer to use a merge commit.

Activity

  1. added
    bugSomething isn't working
    in-progressAn agent is actively working this issue via /implement
    on Oct 14, 2026
  2. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    🛠️ Picked up by /implement - driver claude-code, branch 1375-join-main-history, 2026-10-14T02:42:18.665Z.

  3. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    gc_codex_review — sanitized deferred publication for issue #1375, cycle 1 of 1
    Reviewed revision: f9ee26bacf5a49c553abed8ced27c11f111e28c2065bb274e70dbec028073148

    Architectural read

    Core: the change states the merge strategy at the existing operator decision point and keeps the back-merge PR body and the release guide aligned. It adds no automation. The new assertions protect the wording, and shell quoting keeps it intact in the PR body. Security: workflow permissions, branch selection, and the environment-bound tag are unchanged. No exploitable issue was found.

    Verdict: ship

    Findings

    • (none)
  4. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    gc_codex_review pre-push cycle 1 of 1 complete for issue #1375 on branch '1375-join-main-history'. Posted by the MCP server to enforce the pre-push hard-cap-1 contract (issues #796, #804, #906). Do not edit or delete — used by the next gc_codex_review (uncommitted) invocation to count cycles.

  5. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Review decision record — codex cycle 1 (issue #1375)

    Reviewer: codex
    Cycle: 1
    Verdict: ship

    Architectural read:

    Core: the change states the merge strategy at the existing operator decision point and keeps the back-merge PR body and the release guide aligned. It adds no automation. The new assertions protect the wording, and shell quoting keeps it intact in the PR body. Security: workflow permissions, branch selection, and the environment-bound tag are unchanged. No exploitable issue was found.

    Blocking findings: 0 (clean run)

  6. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Pre-PR base synchronization

    • Source: refs/remotes/origin/dev at 0796c7fcaec1ce9388087cb22eb65bcb89b75165
    • Outcome: already_current
    • Published feature head: 056e15370278a7701786f0b5a0b840f234a158bf
    • Synchronized tree: 57462f0b4962fed3bbf4851cb097b6e739cbdb0d
  7. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Pre-PR base synchronization

    • Source: refs/remotes/origin/dev at 78a1864eef7fd1bbca991a8c0181832e432d088b
    • Outcome: already_current
    • Published feature head: 929c7382e588a8bd5c23b3d711e045dba48e5a64
    • Synchronized tree: 57462f0b4962fed3bbf4851cb097b6e739cbdb0d
  8. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Pre-PR base synchronization

    • Source: refs/remotes/origin/dev at 9cab8c0cd14d34ad67e610a1504cf99a3dc01bb1
    • Outcome: already_current
    • Published feature head: 39de0f2b98df59790403710f5ac0c4830538375e
    • Synchronized tree: 57462f0b4962fed3bbf4851cb097b6e739cbdb0d
  9. Brad-Edwards commented on Oct 14, 2026

    @Brad-Edwards
    CollaboratorAuthor

    Final report — issue #1375 complete

    PR: #1378

    Outcome

    Promotions from dev to main merge cleanly again. The dev ruleset now allows merge commits, main's release history is part of dev, and the release guide and back-merge PR tell the maintainer to use a merge commit for back-merges.

    Join main's release history into dev and allow merge commits for back-merges.

    Files changed

    Modified:

    • pyproject.toml
    • uv.lock

    Reviews

    Traceability reconciliation

    • IMPLEMENTS / TESTS / DOCUMENTS added: 0
    • Links updated: 0
    • Stale links removed: 0

    Status

    • CI: ✅ green
    • SonarCloud: ✅ passed
    • PR ready for user review and merge.
  10. removed
    in-progressAn agent is actively working this issue via /implement
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions