Repository navigation
fix: preserve volumes and complete failed-start recovery - #1387
Merged
Merged
Conversation
3 tasks
Collaborator
Author
|
Ground Control delivery — this pull request delivers issue #952; Phase E runs on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete failed-start recovery already introduced by #1266: preserve anonymous node volumes during non-destructive cleanup, direct recovery commands to the selected project, and account for operational and appliance readiness failures under the start lifecycle lock.
Requirement UIDs
Related Issues
Closes #952
ADR Impact
Changes
Test Plan
Observed regression failures before implementation. The affected-file run passed 807 tests with one skip and one outdated stderr assertion; that assertion and the reviewer’s guest-access test now pass (3 targeted repair tests). Additional acceptance/appliance checks: 95 passed, plus 2 actual guest channel tests. Staged pre-commit and changed-source complexity checks pass. Hosted CI owns whole-tree and real lab qualification.
Ground Control Checks
Traceability
aptl lab startleaves the whole range running with no teardown guidance #952: core lifecycle failure accounting, receipt-owned cleanup and shared recovery rendering; existing requirement links remain valid.Checklist
Documentation
Updated: see diff.