Skip to content

fix: partition shard items with comprehensions for the SonarCloud gate #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brad-Edwards merged 1 commit into from
Oct 1, 2026
Merged

fix: partition shard items with comprehensions for the SonarCloud gate #1406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tools/pytest_shard_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,9 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
raise pytest.UsageError("--shard-count and --shard-index must be supplied together")
index, count = validate_shard_index(shard_index, shard_count)

owned: list[pytest.Item] = []
deselected: list[pytest.Item] = []
for item in items:
(owned if shard_for_nodeid(item.nodeid, count) == index else deselected).append(item)
assignments = [(item, shard_for_nodeid(item.nodeid, count) == index) for item in items]
owned = [item for item, is_owned in assignments if is_owned]
deselected = [item for item, is_owned in assignments if not is_owned]
if deselected:
config.hook.pytest_deselected(items=deselected)
items[:] = owned
Expand Down
Loading