fix(release): pass the repository root when loading the release closure profile - #1408
Merged
Merged
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v6.0.0 release run (36819410412) failed in
build-releaseat the "Generate output-bound release evidence (#1226)" step, before anything reached PyPI:load_python_closure_profiletakes(repo_root, profile_id). #1295 added thegeneratecall site without the repository root, and no test ever rangenerate(), so the first release after #1295 is also the first execution of that line. This PR passesrepo_rootand adds a regression test that runsgenerate()through the real closure-profile load.Requirement UIDs
Related Issues
No issue: remediates the failed v6.0.0 release run's
build-releasejob.ADR Impact
Changes
tools/release_evidence.py:generate()callsload_python_closure_profile(repo_root, profile_id), using the admitted repository root it already holds.tests/test_issue_1226_release_evidence_cli.py: newtest_generate_loads_the_closure_profile_from_the_admitted_repository. It runsgenerate()against the real repository profile and stops at target-environment selection, then asserts that the loaded profile's Python version and platform are the ones selected. It fails with the originalTypeErrorwithout the fix.Test Plan
I reproduced
build-releaselocally under CPython 3.12. The steps weretools.python_closure build,materialize, wheel and sdistsmokewith--offline, thentools.release_evidence generate. Generation now completes and writesbuild-inventory.json,release-evidence-index.json,wheel.cdx.jsonandsdist.cdx.json.The release-evidence, release-publication, workflow-policy and tooling-policy modules pass with integration included (327).
nox -s verify-fast-feedback --base-rev origin/devpasses.Ground Control Checks
Traceability
build-release(110237295033), tagv6.0.0at17ca2a08a0c4af3e)Checklist