Skip to content

test(policy): name the missing conftest installation in the rego runner test #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doublewhy wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

test(policy): name the missing conftest installation in the rego runner test #1566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions implementations/python/tests/test_repo_policy_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,18 +1261,27 @@ def runner(input_document: dict) -> list[PolicyFailure]:
assert [failure.rule_id for failure in failures] == ["structural-check"]


def _verified_conftest_binary() -> Path:
installation = verified_tool_installation.default_installation_root(REPO_ROOT) / "conftest"
binary = next(
(path for path in installation.glob("**/conftest") if path.is_file() and path.stat().st_mode & 0o777 == 0o500),
None,
)
if binary is None:
pytest.fail(
f"no verified conftest installation under {installation}; run `make policy` to install it",
pytrace=False,
)
return binary


@pytest.mark.integration
def test_default_structural_policy_runner_executes_rego(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
) -> None:
repo_root = setup_policy_repo(tmp_path)
binary = next(
path
for path in (verified_tool_installation.default_installation_root(REPO_ROOT) / "conftest").glob("**/conftest")
if path.is_file() and path.stat().st_mode & 0o777 == 0o500
)
assert binary.is_file()
binary = _verified_conftest_binary()
monkeypatch.setattr(conftest_tool, "ensure_conftest", lambda *_args, **_kwargs: binary)

failures = evaluate_repo_policy(
Expand All @@ -1285,6 +1294,28 @@ def test_default_structural_policy_runner_executes_rego(
assert [failure.rule_id for failure in failures] == ["legacy-top-level-root"]


@pytest.mark.parametrize("installed_mode", [None, 0o755], ids=["absent", "unverified-mode"])
def test_rego_runner_test_names_missing_conftest_installation(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
installed_mode: int | None,
) -> None:
installation_root = tmp_path / "installations"
if installed_mode is not None:
unverified = installation_root / "conftest" / "interrupted" / "conftest"
unverified.parent.mkdir(parents=True)
unverified.write_bytes(b"")
unverified.chmod(installed_mode)
monkeypatch.setattr(verified_tool_installation, "default_installation_root", lambda _root: installation_root)

with pytest.raises(pytest.fail.Exception) as failure:
test_default_structural_policy_runner_executes_rego(monkeypatch, tmp_path / "repo")

assert str(failure.value) == (
f"no verified conftest installation under {installation_root / 'conftest'}; run `make policy` to install it"
)


def test_conftest_policy_runner_parses_and_sorts_failures(
monkeypatch: pytest.MonkeyPatch,
tmp_path: Path,
Expand Down
Loading