Repository navigation
Conversation
doublewhy
force-pushed
the
1551-target-snapshot-published-carriers
branch
from
October 13, 2026 12:14
4186b7b to
0bb2a44
Compare
doublewhy
marked this pull request as ready for review
October 13, 2026 12:38
doublewhy
marked this pull request as draft
October 13, 2026 19:39
doublewhy
force-pushed
the
1551-target-snapshot-published-carriers
branch
from
October 13, 2026 22:34
0bb2a44 to
b107f8d
Compare
…conformance The target-snapshot case validated a hand-built payload that dropped realization_envelope, realization_provenance and the other carriers the /snapshot route publishes. It now validates published_snapshot_payload(), the route's own serializer (a public import of raes_runtime.control_plane_api_models for raes_conformance in adr_policy.yaml; control_plane.py stays unchanged because the #1581 multi-rev1 crossing bundle pins its digest), and runs semantic checks only on a schema-valid payload. Closes #1551
doublewhy
force-pushed
the
1551-target-snapshot-published-carriers
branch
from
October 13, 2026 23:07
b107f8d to
26613f0
Compare
doublewhy
marked this pull request as ready for review
October 14, 2026 03:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target conformance's
target-snapshotcase validated a hand-built payload that omittedrealization_envelope,realization_provenanceand the other carriers the/snapshotroute publishes, and skipped its credential redaction (RS-1 of the #1344 fixture-provenance audit). The case now validates the payload the route's own serializer publishes, with semantic checks only after the schema check passes, so an invalid published envelope or provenance entry failstarget-snapshotwith the existingconformance.schema-invaliddiagnostic. Report shape and wire output are unchanged.Requirement UIDs
## Requirementssection and never had a scope file (git log --allon its path is empty).Related Issues
Closes #1551
Context, not closed here: #1344, #1461 (open audit record), #1553 (RS-2) and #1555 (RS-3).
ADR Impact
runtime-snapshot-v1payload"; no second serializer).Changes
raes_runtime/control_plane_api_models.py:published_snapshot_payload(new, public) holds_snapshot_model's former body, redaction included;_snapshot_modelvalidates its result, so the route is unchanged.tools/policy/adr_policy.yamladdsraes_runtime.control_plane_api_modelstoraes_conformance's public imports.control_plane.pyis unchanged (see design deviations).raes_conformance/conformance/target_probes.py:_hermetic_snapshot_casevalidatespublished_snapshot_payload(control_plane.get_snapshot()), runs semantic checks only on a schema-valid payload (assemantics.py::_fixture_case_diagnosticsdoes), and the hand-built_hermetic_snapshot_payloadis deleted.Done-when matrix (bullets verbatim; tests in
test_issue_1551_target_snapshot_published_carriers.py, selected bycanonical / test-shard (0-3); evidence: CI run 38482282315):realization_envelopeorrealization_provenanceis invalid.target_probes.py:_hermetic_snapshot_case,control_plane_api_models.py:published_snapshot_payloadtest_target_snapshot_rejects_invalid_published_carrier[envelope],[provenance]fail (target-snapshot.passedis True);test_target_snapshot_validates_the_route_payloadfails (the case never reads the published snapshot).docs/research/fixture-provenance/index.mdand its row ininventory.mdrecord the fix.Test Plan
pytest implementations/python/tests/test_issue_1551_target_snapshot_published_carriers.pypassed (3 passed).With the two source files reverted to dev, all 3 tests fail (matrix); without the schema-first order, both carrier cases raise
pydantic_core.ValidationErrorfrom the semantic step.Regression: the 81 modules referencing
run_target_conformance,_snapshot_model,target_probesorraes_runtime.control_planegave 2085 passed, 2 skipped.RAES_DOCKER_INTEGRATION_REQUIRED=1 pytest -m docker test_reference_backend_docker_integration.py: 2 passed, with the real-container backend'starget-snapshoton the published payload.Evidence, collected on 04d003e (dev 348c490 plus this fix, clean tree): the 6 pinned specification artifacts ran through
_execute_artifact(42 stages: 38 passed, 4 preregistered non-execution) andrecompute_analysis(10 of 10 load-bearing passed);replay_caseran the 10 retained SDL cases,raes processorthe 4 production cases and pytest the 14 participant functions (all 20 observations as expected).research_capture recordwrotecapture-908b9484...andcapture-15e1b6e9...(templatesc9ca186a,3bad3945). Drift: only the formal first command (retained-case-replay, as run) and Python 3.12.3. Both checkers pass at the head and on themerge-treeresult; the five evidence test modules gave 173 passed;nox -s contractspassed.nox -s verify-fast-feedback -- --base-rev origin/dev,nox -s lintandnox -s docs-localpassed; the full completion suite is required in CI before merge. CI at head 26613f0: 32 checks pass, Docsdeployskipped (run 38482282315).Ground Control Checks
make policypassed, including the module-boundary check for the new public import.Traceability
implementations/python/packages/raes_runtime/control_plane_api_models.py,implementations/python/packages/raes_conformance/conformance/target_probes.pyimplementations/python/tests/test_issue_1551_target_snapshot_published_carriers.pyChecklist
CHANGELOG.mdfrom it)FM0 (structural: an existing published payload validated against its existing schema). No executable or runtime adoption is claimed. No contract model or schema changed. Design deviations: content-addressed captures (since #1449); a policy public import instead of a
control_plane.pyre-export (#1581'smulti-rev1crossing bundle pins its digest).Documentation
Updated:
docs/explain/reference/backend-conformance.md("Target Conformance Reference Scenario").