Skip to content

feat: restore review dashboard polish - #39

Merged
Brad-Edwards merged 3 commits into
devfrom
33-frontend-polish
Jul 12, 2026
Merged

Brad-Edwards merged 3 commits into
devfrom
33-frontend-polish

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Collaborator

Summary

Restores the review dashboard experience inside the Django workbench while keeping the multi-user security boundary intact.

Requirement UIDs

  • (none — bug/refactor/maintenance run; see Traceability section below)

Related Issues

Closes #33

ADR Impact

  • ADR-001

Changes

  • Rebuilt revision overview as an Overview / Techniques / Modules dashboard with KPI metrics, tactic bars, progression cards, integrity digests, clickable rows, and richer module tiles.
  • Added branded public/auth chrome: landing page, sign-in path, footer/privacy/cookie notice, favicon/mark, styled login, and branded 404/500 pages.
  • Moved admin off the default path behind one validated ACES_WORKBENCH_ADMIN_PATH setting used by URLs, CSP exclusion, doctor output, docs, and tests.
  • Added account deletion confirmation and strengthened hardening/dashboard tests.

Test Plan

  • Unit tests pass (make test)
  • Integration tests pass if applicable (make integration)
  • make check passes (Spotless, SpotBugs, Error Prone, Checkstyle, JaCoCo)
  • No coverage regression

uv run ruff check .; uv run ruff format --check .; uv run pytest; uv run --group docs mkdocs build --strict; pre-commit and pre-push hooks passed.

Ground Control Checks

  • make policy passes
  • gc_evaluate_quality_gates passes or is unchanged by this repo-only change
  • gc_run_sweep reviewed; findings fixed or recorded with rationale

Traceability

  • IMPLEMENTS: src/aces_scenario_workbench/workbench/templates/workbench/revision_overview.html, src/aces_scenario_workbench/workbench/views.py, src/aces_scenario_workbench/workbench/static/workbench/app.css, src/aces_scenario_workbench/workbench/static/workbench/app.js, src/aces_scenario_workbench/settings.py, src/aces_scenario_workbench/urls.py, src/aces_scenario_workbench/accounts/views.py
  • TESTS: tests/test_review.py, tests/test_views.py, tests/test_hardening.py, tests/test_account.py

Checklist

  • Code follows project coding standards (docs/CODING_STANDARDS.md)
  • No business logic in API layer
  • Domain layer has no framework imports
  • Envers @Audited on new entities if applicable
  • Changelog fragment added at changelog.d/33.changed.md
  • Architectural docs updated if stack, package structure, or key behaviors changed

Documentation

Updated: see diff.

@sonarqubecloud

Copy link
Copy Markdown

@Brad-Edwards
Brad-Edwards marked this pull request as ready for review July 12, 2026 06:03
@Brad-Edwards
Brad-Edwards merged commit 70b6e91 into dev Jul 12, 2026
6 checks passed
@Brad-Edwards
Brad-Edwards deleted the 33-frontend-polish branch July 12, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant