Skip to content

feat: add scenario network diagram and review context - #46

Merged
Brad-Edwards merged 2 commits into
devfrom
feat/network-diagram
Jul 14, 2026
Merged

Brad-Edwards merged 2 commits into
devfrom
feat/network-diagram

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Collaborator

Summary

Add a readable, interactive network diagram and give reviewers the participant, organizer, evidence, and related-system context needed to evaluate each challenge.

Requirement UIDs

  • (none — bug/refactor/maintenance run; see Traceability section below)

Related Issues

Closes #33

ADR Impact

  • ADR-021

Changes

  • Render scenario subnets, systems, services, actors, and directed network relationships in an interactive topology canvas.
  • Enrich imported challenges with participant objectives and hints, organizer details, and automatically resolved related systems and applications.
  • Use canonical pack identity during synchronization and preserve host-to-network membership from the scenario definition.

Test Plan

  • Unit tests pass (make test)
  • Integration tests pass if applicable (make integration)
  • make check passes (Spotless, SpotBugs, Error Prone, Checkstyle, JaCoCo)
  • No coverage regression

uv run pytest (140 passed); npm run build; npm run typecheck; uv run pre-commit run --all-files; live-data browser review completed.

Ground Control Checks

  • make policy passes
  • gc_evaluate_quality_gates passes or is unchanged by this repo-only change
  • gc_run_sweep reviewed; findings fixed or recorded with rationale

Traceability

Checklist

  • Code follows project coding standards (docs/CODING_STANDARDS.md)
  • No business logic in API layer
  • Domain layer has no framework imports
  • Envers @Audited on new entities if applicable
  • Changelog fragment added at changelog.d/+network-diagram.changed.md
  • Architectural docs updated if stack, package structure, or key behaviors changed

Documentation

Verified unchanged: no documentation surface in scope.

@sonarqubecloud

Copy link
Copy Markdown

@Brad-Edwards
Brad-Edwards merged commit 6c4e0f8 into dev Jul 14, 2026
6 checks passed
@Brad-Edwards
Brad-Edwards deleted the feat/network-diagram branch July 14, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant