Skip to content

feat: simplify topology and align challenge status - #48

Merged
Brad-Edwards merged 1 commit into
devfrom
fix/simple-network-diagram
Jul 15, 2026
Merged

Brad-Edwards merged 1 commit into
devfrom
fix/simple-network-diagram

Conversation

@Brad-Edwards

Copy link
Copy Markdown
Collaborator

Summary

  • replace the dense topology view with a focused React Flow and Dagre network diagram using subnet groups, compact host nodes, and deduplicated links
  • remove the requested scenario tabs, topology tables, and readiness column while adding password changes to Profile
  • recognize source-implemented, automated-proven, and participant-proven as completed challenge states during import

Root cause

The importer treated only source-implemented as implemented, so automated-proven and participant-proven challenges were incorrectly shown as planned.

Data

The current deployed scenario data has already been corrected to 28 implemented and 32 planned challenges across one current revision.

Validation

  • 148 tests passed
  • 96% coverage
  • frontend production build passed

@gitguardian

gitguardian Bot commented Jul 15, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
34832911 Triggered Generic Password 25b0871 tests/test_account.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sonarqubecloud

Copy link
Copy Markdown

@Brad-Edwards
Brad-Edwards marked this pull request as ready for review July 15, 2026 01:51
@Brad-Edwards
Brad-Edwards merged commit 0f5cef9 into dev Jul 15, 2026
6 checks passed
@Brad-Edwards
Brad-Edwards deleted the fix/simple-network-diagram branch July 15, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant