Repository navigation
feat: launch public connector site and harden scene review - #7
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR replaces the private ChangesPortable skill migration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description includes a summary and validation details, but its main claims about GitHub Pages, image previews, finalize behavior, and spatial checks are not supported by the file summaries or stated objectives. It also omits the required Blender impact section. Resolution Rewrite the summary to describe the portable Blender agent skill, MCP client setup documentation, guidance migration, and package validation changes shown in the pull request. Keep only implementation claims supported by the changes. Add a Blender impact section with tested versions, scene mutation risk, and rollback behavior, and clarify the validation performed. ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/validate-package.mjs`:
- Around line 11-17: Update the package validation assertions in
scripts/validate-package.mjs to verify every expected shipped reference file,
rather than checking only
skills/using-vipermesh-blender/references/spatial-validation.md. Prefer
validating the complete npm pack dry-run file list if that is the established
approach; otherwise add assertions for all expected reference files while
preserving the existing skill and data/tool-guides checks.
In `@skills/using-vipermesh-blender/references/scene-operations.md`:
- Around line 34-36: Update the completion workflow around
run_blender_scene_stage so blend-file saving occurs only for mutating tasks when
the user explicitly provides and approves blendPath. Preserve inspection-only
and render/export-only workflows without saving or overwriting a blend file,
while continuing to produce any requested render or export artifacts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8a3b9fd8-a01f-4f28-a4fc-fa52ba71573e
📒 Files selected for processing (36)
CHANGELOG.mdREADME.mddata/tool-guides/aesthetic-quality-guide.mddata/tool-guides/animation-guide.mddata/tool-guides/architectural-completeness-guide.mddata/tool-guides/blend-file-health-guide.mddata/tool-guides/blender-docs-lookup-guide.mddata/tool-guides/camera-guide.mddata/tool-guides/execute-code-guide.mddata/tool-guides/export-guide.mddata/tool-guides/lighting-guide.mddata/tool-guides/local-asset-guide.mddata/tool-guides/material-realism-guide.mddata/tool-guides/materials-guide.mddata/tool-guides/modifiers-guide.mddata/tool-guides/object-assembly-guide.mddata/tool-guides/render-guide.mddata/tool-guides/rigging-guide.mddata/tool-guides/scene-composition-guide.mddata/tool-guides/scene-management-guide.mddata/tool-guides/spatial-positioning-guide.mddata/tool-guides/weight-painting-guide.mddocs/client-setup.mddocs/portable-blender-mcp.mdlib/portable-mcp/guidance.tslib/portable-mcp/server.tsllms.txtpackage.jsonscripts/validate-package.mjsskills/using-vipermesh-blender/SKILL.mdskills/using-vipermesh-blender/references/character-animation-export.mdskills/using-vipermesh-blender/references/geometry-materials-assets.mdskills/using-vipermesh-blender/references/scene-operations.mdskills/using-vipermesh-blender/references/spatial-validation.mdskills/using-vipermesh-blender/references/visual-presentation.mdtests/conformance.ts
💤 Files with no reviewable changes (20)
- data/tool-guides/rigging-guide.md
- data/tool-guides/export-guide.md
- data/tool-guides/execute-code-guide.md
- data/tool-guides/aesthetic-quality-guide.md
- data/tool-guides/blender-docs-lookup-guide.md
- data/tool-guides/modifiers-guide.md
- data/tool-guides/animation-guide.md
- data/tool-guides/scene-composition-guide.md
- data/tool-guides/object-assembly-guide.md
- data/tool-guides/local-asset-guide.md
- data/tool-guides/lighting-guide.md
- data/tool-guides/material-realism-guide.md
- data/tool-guides/weight-painting-guide.md
- data/tool-guides/render-guide.md
- data/tool-guides/camera-guide.md
- data/tool-guides/blend-file-health-guide.md
- data/tool-guides/architectural-completeness-guide.md
- data/tool-guides/scene-management-guide.md
- data/tool-guides/spatial-positioning-guide.md
- data/tool-guides/materials-guide.md
| assert.ok(fs.existsSync("skills/using-vipermesh-blender/SKILL.md")) | ||
| assert.ok( | ||
| fs.existsSync( | ||
| "skills/using-vipermesh-blender/references/spatial-validation.md" | ||
| ) | ||
| ) | ||
| assert.ok(!fs.existsSync("data/tool-guides")) |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick win
Validate every shipped skill reference, not just one.
These assertions cover only spatial-validation.md; a missing package reference could pass validation and fail at runtime when requested. Assert all expected reference files, or inspect the npm pack --dry-run --json file list.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/validate-package.mjs` around lines 11 - 17, Update the package
validation assertions in scripts/validate-package.mjs to verify every expected
shipped reference file, rather than checking only
skills/using-vipermesh-blender/references/spatial-validation.md. Prefer
validating the complete npm pack dry-run file list if that is the established
approach; otherwise add assertions for all expected reference files while
preserving the existing skill and data/tool-guides checks.
| Before reporting completion, confirm that the requested objects and changes | ||
| exist, inspect any high-risk structural relationships, save the intended blend | ||
| file, and produce the visual or export artifact requested by the user. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Make blend-file saving conditional on the user’s requested output.
run_blender_scene_stage exposes renderPath and blendPath as optional, and the skill supports inspection-only sessions. Requiring every workflow to save a blend file can cause an unsolicited write or overwrite when no destination was requested. Save only for mutating tasks with an explicit user-approved path.
🛡️ Proposed wording
-Before reporting completion, confirm that the requested objects and changes
-exist, inspect any high-risk structural relationships, save the intended blend
-file, and produce the visual or export artifact requested by the user.
+Before reporting completion, confirm that the requested objects and changes
+exist and inspect any high-risk structural relationships. For mutating tasks,
+save the blend file only when the user has requested an output path; produce
+visual or export artifacts only when requested.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Before reporting completion, confirm that the requested objects and changes | |
| exist, inspect any high-risk structural relationships, save the intended blend | |
| file, and produce the visual or export artifact requested by the user. | |
| Before reporting completion, confirm that the requested objects and changes | |
| exist and inspect any high-risk structural relationships. For mutating tasks, | |
| save the blend file only when the user has requested an output path; produce | |
| visual or export artifacts only when requested. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/using-vipermesh-blender/references/scene-operations.md` around lines
34 - 36, Update the completion workflow around run_blender_scene_stage so
blend-file saving occurs only for mutating tasks when the user explicitly
provides and approves blendPath. Preserve inspection-only and render/export-only
workflows without saving or overwriting a blend file, while continuing to
produce any requested render or export artifacts.
|
@coderabbitai pause The existing review has been inspected. Both findings are addressed in the |
|
✅ Action performedReviews paused. |
Ker102
changed the title
Public connector launch and result review
Publish the repository's static overview through GitHub Pages and improve the
agent's result review. Image-producing calls can attach bounded previews directly.
Finalize can preserve the artist's presentation, render without a blend save,
and withhold output when an explicit spatial check fails. Guidance replaces fixed
preview counts with task-specific inspection and reports unresolved defects.
Synchronize the current addon/tool metadata, refresh the dependency lock, verify
every packaged skill reference, and prepare the aligned 1.3.0 release.
Validation: standalone typecheck, MCP conformance including inline image transport,
build, package validation, dependency audit; focused scene-stage and waitlist
handler checks. The Studio waitlist is deployed separately on Vercel.
The previous CodeRabbit pass has been inspected and its two actionable findings
are addressed. A second review cycle is intentionally skipped for this launch
batch; normal CI remains required. This does not claim a new live benchmark or
comprehensive artist acceptance of every Blender tool.