Skip to content

Add high-level merging class for RADOLAN method#81

Open
cchwala wants to merge 18 commits intoOpenSenseAction:mainfrom
cchwala:add_radolan_highlevel_func
Open

Add high-level merging class for RADOLAN method#81
cchwala wants to merge 18 commits intoOpenSenseAction:mainfrom
cchwala:add_radolan_highlevel_func

Conversation

@cchwala
Copy link
Copy Markdown
Member

@cchwala cchwala commented Mar 27, 2026

This PR adds a class based on MergeBase to run the RADOLAN adjustment provided by the rh_to_rw() function. As a first pragmatic step, I keep rh_to_rw() as it is and transform the data to pd.DataFrame as needed using the already existing functions and/or example code for that, plus some required adaptions.

TODO:

  • add functioning MergeRADOLAN class
  • adapt example notebook
  • clean up example notebook and consider renaming it
  • add tests

cchwala added 4 commits March 27, 2026 15:07
…stments to work. Later, the interpolator could also be cached like in the other merging classes.
…ample notebook (which is a modified version of the existing notebook that did use the low-level functions)

Several minor things had to be fixed in the module files.

TODO is to check if and how it works when passing CML and gauge or when passing gauges only. There is some logic somewhere that might needs adjustment.
… notebook a few times to see how results change (they do) and results (hexbin plot and metrics) are now the same or very similar to what was there before with the old low-level code notebook. Good!
@cchwala
Copy link
Copy Markdown
Member Author

cchwala commented Mar 27, 2026

This updated notebook from 030c5cc shows the same metrics as before in this notebook when the old lower-level function was used. The hexbin plot also looks very very similar. This means, it works! But tests need still to be added.

@cchwala cchwala changed the title Add high-level merging class for RADOLAN method [WIP] Add high-level merging class for RADOLAN method Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.30%. Comparing base (62f1b87) to head (5bdd29b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   95.37%   96.30%   +0.93%     
==========================================
  Files          11       11              
  Lines         800      840      +40     
==========================================
+ Hits          763      809      +46     
+ Misses         37       31       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cchwala cchwala requested a review from eoydvin April 8, 2026 20:49
@cchwala cchwala changed the title [WIP] Add high-level merging class for RADOLAN method Add high-level merging class for RADOLAN method Apr 8, 2026
@cchwala
Copy link
Copy Markdown
Member Author

cchwala commented Apr 8, 2026

@eoydvin This is now ready and it would be good if you could have a brief look. Some comments:

  1. The main change is the MergeRADOLAN class in merge.py.
  2. There are test for this new class, which are okay IMO.
  3. I had to also do some minor changes in some of the RADOLAN module files.
  4. I added the RADOLAN method to the OpenMRG and OpenRainER high-level notebooks. RADOLAN seem show its skill with OpenRainER more (high PCC) than with OpenMRG. This is not (yet 😉) a competition, though. Results look okay for sure, that is most important currently.
  5. There is also still the openMRG_case_RADOLAN.ipynb which was the only notebook where RADOLAN was used before. I also updated it so that it uses MergeRADOLAN. Currently the notebook is a bit obsolete, but in the future we could extend it to show some of the intermediate radar fields from the RADOLAN method and dig a bit in into the details. Hence, I would keep it in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant