Skip to content

Add load_openmesh() function for OpenMesh example data #120

Merged
cchwala merged 6 commits intoOpenSenseAction:mainfrom
drorjac:add-openmesh-example-data
Apr 7, 2026
Merged

Add load_openmesh() function for OpenMesh example data #120
cchwala merged 6 commits intoOpenSenseAction:mainfrom
drorjac:add-openmesh-example-data

Conversation

@drorjac
Copy link
Copy Markdown
Contributor

@drorjac drorjac commented Apr 5, 2026

  • Adds load_openmesh() to example_data.py to download and load three OpenMesh datasets (CML, PWS, ASOS reference stations) for a 20-day period over New York City
  • Adds notebook section in Explore_example_data.ipynb with a PWS+ASOS accumulated rainfall map, a CML RSL std map, and a time series comparison plot
  • Adds tests covering CML coordinates, PWS lon values, and ASOS station IDs/temperature
  • Updates CHANGELOG

Note

CI tests will fail until OpenSenseAction/opensense_example_data#6 is merged, as the data files are not yet in the upstream example data repo.

drorjac and others added 6 commits April 5, 2026 10:49
Adds download/load function for OpenMesh example data (CML, PWS, ASOS
over NYC), corresponding test, CHANGELOG entry, and Explore_example_data
notebook section following the OpenRainER pattern.
- Add PWS + ASOS accumulated rainfall map (shared axes, single colorbar)
- Add CML RSL std map with PWS locations as reference dots
- Add time series comparison of mean PWS/ASOS rainfall vs CML RSL
- Remove debug print cell

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These NaN assertion fixes belong in a separate PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cchwala
Copy link
Copy Markdown
Member

cchwala commented Apr 7, 2026

Thanks @drorjac!

Is the download in the tests failing because the dataset PR has not yet been merged or is there another problem?

EDIT: I saw your comment in the dataset PR that it has to be merged first. Okay. So let's do that!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.90%. Comparing base (6293966) to head (4ea29aa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   98.88%   98.90%   +0.02%     
==========================================
  Files           7        7              
  Lines         808      823      +15     
==========================================
+ Hits          799      814      +15     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cchwala
Copy link
Copy Markdown
Member

cchwala commented Apr 7, 2026

There is a problem with some tests, but this is not stemming from your changes. I opened an issue for this problem, see #121, and we have to fix it separately.

Code and notebook looks good. I am merging this now. Thanks @drorjac for this contribution!

@cchwala cchwala merged commit a4291bb into OpenSenseAction:main Apr 7, 2026
12 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants