Add load_openmesh() function for OpenMesh example data #120
Merged
cchwala merged 6 commits intoOpenSenseAction:mainfrom Apr 7, 2026
Merged
Add load_openmesh() function for OpenMesh example data #120cchwala merged 6 commits intoOpenSenseAction:mainfrom
cchwala merged 6 commits intoOpenSenseAction:mainfrom
Conversation
Adds download/load function for OpenMesh example data (CML, PWS, ASOS over NYC), corresponding test, CHANGELOG entry, and Explore_example_data notebook section following the OpenRainER pattern.
- Add PWS + ASOS accumulated rainfall map (shared axes, single colorbar) - Add CML RSL std map with PWS locations as reference dots - Add time series comparison of mean PWS/ASOS rainfall vs CML RSL - Remove debug print cell Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These NaN assertion fixes belong in a separate PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Thanks @drorjac!
EDIT: I saw your comment in the dataset PR that it has to be merged first. Okay. So let's do that! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 98.88% 98.90% +0.02%
==========================================
Files 7 7
Lines 808 823 +15
==========================================
+ Hits 799 814 +15
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_openmesh()toexample_data.pyto download and load three OpenMesh datasets (CML, PWS, ASOS reference stations) for a 20-day period over New York CityExplore_example_data.ipynbwith a PWS+ASOS accumulated rainfall map, a CML RSL std map, and a time series comparison plotNote
CI tests will fail until OpenSenseAction/opensense_example_data#6 is merged, as the data files are not yet in the upstream example data repo.