Repository navigation
Send metaData.version only where a Delta Sharing response defines it - #193
Merged
Merged
Conversation
littlegrasscao
requested review from
chakankardb,
hueyhuilonghan and
linzhou-db
as code owners
November 13, 2026 02:11
This was referenced Nov 13, 2026
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). |
littlegrasscao
force-pushed
the
fix/response-shape
branch
from
November 13, 2026 07:18
fbace38 to
3159c9f
Compare
littlegrasscao
force-pushed
the
fix/response-shape
branch
from
November 13, 2026 07:49
3159c9f to
d3b2b25
Compare
zhu-tom
approved these changes
Nov 13, 2026
A snapshot or metadata response carries no version in its metaData, even when it reads a given version or timestamp: the version is in the Delta-Table-Version header. A Change Data Feed's leading metaData carries a version only with includeHistoricalMetadata and never a size or file count. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
littlegrasscao
force-pushed
the
fix/response-shape
branch
from
November 13, 2026 20:46
d3b2b25 to
559b88c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #192.
Problem
Query Table and Query Table Metadata responses put the queried version into
metaData.versionon version and timestamp queries, and carried the latest snapshot's size and file count in the metaData of a Change Data Feed. Delta Sharing sendsmetaData.versiononly on a Change Data Feed response withincludeHistoricalMetadata=true, and never a size or file count on a Change Data Feed; the version of a version or timestamp query travels only in theDelta-Table-Versionheader. Clients that compare whole metadata objects fail on the extra fields.Change
DeltaTableMetadataReaderandDeltaTableQueryReaderwritemetaData.versionas null for metadata and snapshot query responses; the version stays in theDelta-Table-Versionheader.includeHistoricalMetadata, and neversizeornumFiles. The metaData of astartingVersionquery keeps the starting version and the checksum's size and file count.Test plan
mvn -pl opensharing-server-core,opensharing-server clean test(Java 17) passes; cloud-gated integration classes need credentials and run in CI.This pull request and its description were written by Isaac.