Repository navigation
server: add global HTTP error handling (2/N) - #20
Closed
littlegrasscao wants to merge 42 commits into
Closed
littlegrasscao wants to merge 42 commits into
littlegrasscao wants to merge 42 commits into
Conversation
added 30 commits
August 26, 2026 17:20
Give the repo a GitHub Actions workflow so PRs and main are checked automatically, running the server suite when that module is present.
Match the reference server's coordinates and Java 21 / Spring Boot 3.5.3 from the draft implementation PR, with a context-load test, so pull-request CI exercises mvn verify instead of skipping.
Drop the skip path now that server/ is in the tree, pin the runner to ubuntu-24.04, and pin checkout, setup-java, and upload-artifact to the same commit SHAs Delta Sharing uses.
OpenSharing feature keys arrive in later PRs as each area lands.
added 12 commits
September 1, 2026 14:02
Catalog exception types and GlobalExceptionHandler only; OpenSharing configuration properties arrive with the features that need them.
Drop the server() sentinel and isServer(); access-denied messages always name the caller.
Replace the two thin subclasses with CatalogException.Kind and static factories; GlobalExceptionHandler maps each kind to the same responses as before.
Keep CatalogException subclasses for each failure shape, but fold access denied and catalog authentication into CatalogAuthorizationException instead of two parallel types.
CatalogAuthorizationException no longer distinguishes reason; both map to 403 PERMISSION_DENIED with the exception message.
Catalog-specific exception types and their HTTP mapping belong with the catalog connector PR, where connector code translates native catalog failures into sharing-server exceptions.
This was referenced Sep 1, 2026
Collaborator
Author
|
Closing as superseded: this split was cut against the reference server as it existed on 2026-09-01, before the module split (opensharing-server-core/opensharing-server), Unity Catalog integration, embedding, and the current auth model. #14 has moved well past this. Restarting the split against #14's current state instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2/N.
Adds
GlobalExceptionHandler— a@RestControllerAdvicethat maps controller-layer failures to the protocol{errorCode, message}JSON shape:ApiException(domain errors from stores and controllers)Catalog-specific exception types and their HTTP mapping arrive with the catalog connector PR.
Test plan
cd server && mvn test