Repository navigation
Say how a host that supplies its own Transactions gets OpenSharing's schema - #201
Merged
Merged
Conversation
…schema The Flyway migrations and JpaTransactions ship only in opensharing-server, so a host that embeds opensharing-server-core with its own Transactions has to create the tables itself. RELEASE.md said a host must not. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
littlegrasscao
requested review from
chakankardb,
hueyhuilonghan and
linzhou-db
as code owners
November 16, 2026 18:28
|
✅ OpenCodeReview: Review skipped: no items were selected. |
Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Sun Cao <sun.cao+data@databricks.com>
zhu-tom
approved these changes
Nov 16, 2026
littlegrasscao
enabled auto-merge (squash)
November 16, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE.mdsays the schema is created by Flyway on startup and that "a host must not create or alter OpenSharing's tables itself". But the Flyway migrations andJpaTransactionsship only inopensharing-server. A host that embedsopensharing-server-coreand supplies its ownTransactionsnever runs them, so it has to create the tables itself.This rewords the paragraph:
opensharing-server'sdb/migration.Transactionscreates the tables in its own migrations, exactly as those migrations define them, and adds each new one when it upgrades.Documentation only; no code changes.
This pull request and its description were written by Isaac.