Feature | Extend Swagger Coverage for controller OAuth2ElectionsApiController… #419
Conversation
andrestejerina97
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthelectionsapicontroller
branch
from
60e41ee to
e8e90dc
Compare
andrestejerina97
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthelectionsapicontroller
branch
from
e8e90dc to
09fc7e3
Compare
andrestejerina97
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthelectionsapicontroller
branch
3 times, most recently
from
fa093a1 to
561cbd8
Compare
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
Incorrect namespace as per project standards for Swagger
App\Swagger\security should be App\Swagger\schemas
Public endpoints have the wrong path.
Wrong:
/api/v1/elections/current
Right:
/api/public/v1/elections/current
Wrong
/api/v1/elections/current/candidates
Right
/api/public/v1/elections/current/candidates
Wrong
/api/v1/elections/current/candidates/gold
Right
/api/public/v1/elections/current/candidates/gold
caseylocker
left a comment
caseylocker
left a comment
There was a problem hiding this comment.
The 3 public endpoints are defined in routes/public_api.php which has prefix api/public/v1 (see RouteServiceProvider.php:110).
Documented (incorrect):
/api/v1/elections/current
/api/v1/elections/current/candidates
/api/v1/elections/current/candidates/gold
Actual (correct):
/api/public/v1/elections/current
/api/public/v1/elections/current/candidates
/api/public/v1/elections/current/candidates/gold
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthelectionsapicontroller
branch
from
812ef91 to
903c6c6
Compare
|
@andrestejerina97 please review conflicts |
matiasperrone-exo
added
the
documentation
matiasperrone-exo
changed the title
matiasperrone-exo
changed the title
smarcet
force-pushed
the
main
branch
4 times, most recently
from
c6ecdd0 to
728ae67
Compare
ref: https://app.clickup.com/t/86b6wkh9k