-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SummitSelectedPresentationListApiController
#423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a99a175 to
c38cdc7
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo
Wrong namespace in security schema:
// Current (line 3)
namespace App\Swagger\Security;
// Should be
namespace App\Swagger\schemas;
Wrong x: parameter key (8 occurrences): Lines 85, 155, 222, 295, 361, 466, 548 all have:
// Current
x: ["authz_groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]],
// Should be
x: ["required-groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]],
e23bdff to
b8a15ee
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'removePresentationFromMyIndividualList' in app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSelectedPresentationListApiController.php is a Delete operation but the response is 201 with 'Created' description. Technically correct, based on the underlying code, but the description can be confusing. Change the description to "Removed from List" so...
new OA\Response(
response: 201,
description: "Created", // ← Incorrect for DELETE operation
becomes
new OA\Response(
response: 201,
description: "Removed from list",
…sentationListApiController`
- moves anyOf to not be in the required, and properties there should be in the main properties param.
711976c to
c51add6
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
c6ecdd0 to
728ae67
Compare
Task:
Ref: https://app.clickup.com/t/86b6wkh94