Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 20, 2025
@matiasperrone-exo matiasperrone-exo self-assigned this Oct 20, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitselectedpresentationlistapicontroller branch from a99a175 to c38cdc7 Compare October 22, 2025 15:41
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 24, 2025
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo
Wrong namespace in security schema:
// Current (line 3)
namespace App\Swagger\Security;

// Should be
namespace App\Swagger\schemas;

Wrong x: parameter key (8 occurrences): Lines 85, 155, 222, 295, 361, 466, 548 all have:
// Current
x: ["authz_groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]],

// Should be
x: ["required-groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]],

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitselectedpresentationlistapicontroller branch from e23bdff to b8a15ee Compare December 5, 2025 15:31
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'removePresentationFromMyIndividualList' in app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSelectedPresentationListApiController.php is a Delete operation but the response is 201 with 'Created' description. Technically correct, based on the underlying code, but the description can be confusing. Change the description to "Removed from List" so...

new OA\Response(
    response: 201,
    description: "Created",  // ← Incorrect for DELETE operation

becomes

new OA\Response(
    response: 201,
    description: "Removed from list",

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitselectedpresentationlistapicontroller branch from 711976c to c51add6 Compare December 10, 2025 21:31
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@smarcet smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants