Repository navigation
sleep: tag each night observation with the window it was staged over - #110
Conversation
|
Sorry @abdulsaheel, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 21 hours and 42 minutes by commenting |
Reviewer's GuideData structuresAdd optional staged-window timestamps to each night observation so callers can identify which night it represents.
APIExtend the epoch-classification interface to accept the staged window timestamps.
Uses of the APIPass the pooled epoch-run bounds into classification on the epoch-rows path.
ImplementationDerive the observation window from accelerometer timestamps and attach it when recording the observation.
TestsVerify that an observation records the bounds of the accelerometer window staged by cardioStager.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
a recorded night observation only carried its epoch count, so a caller that stages several sessions in one search window (the night it wants plus a longer session of the day before) could not tell which observation was which. edge picked the longest one, which can fold the wrong night into the rolling profile.
each observation now has
startTsSec/endTsSec, the window it was staged over, fromcardioStager(the accel timestamps) and from the epoch-rows path (the pooled runs). both are null when a caller does not know them, so nothing changes for existing callers.Summary by Sourcery
Tag recorded sleep observations with their staging windows so callers can reliably match each observation to the intended night.
New Features:
Bug Fixes:
Enhancements:
Tests:
Summary by CodeRabbit